383 custom data logger #523
Conversation
|
Open:
|
src/main/java/com/xceptance/xlt/report/providers/CustomLogsReportProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xceptance/xlt/report/providers/CustomLogsReportProvider.java
Outdated
Show resolved
Hide resolved
|
Optional feature: Before/while adding a custom log file to the zip archive, count the lines of the input file and remember the total number per scope for later display in the report as a new table column. |
| if (file.getType() == FileType.FOLDER && !XltConstants.CONFIG_DIR_NAME.equals(file.getName().getBaseName().toString())) | ||
| { | ||
| for (final FileObject fo : file.getChildren()) | ||
| { | ||
| findLogs(fo); | ||
| } | ||
| } |
There was a problem hiding this comment.
I would like to avoid combining the file type check with another condition. Please move the second condition to a new if inside the body of this if.
| final boolean isCompressed = "gz".equalsIgnoreCase(file.getName().getExtension()); | ||
|
|
||
| InputStream in = isCompressed ? | ||
| new GZIPInputStream(file.getContent().getInputStream(), 1024 * 16) : //TODO is my data EVER zipped? it should be, but how does it happen? | ||
| file.getContent().getInputStream(); |
There was a problem hiding this comment.
Custom data is not gzipped at the moment, so we can remove this code.
There was a problem hiding this comment.
I thought the overall goal was to have all data zipped, so instead if removing this we should get the custom data zipped?
|
|
||
| FileObject results = ((ReportGeneratorConfiguration) getConfiguration()).getResultsDirectory(); | ||
|
|
||
| baseDir = results.getPath(); |
There was a problem hiding this comment.
When creating the report from a result archive, this won't work as the results directory is inside the archive.
To reproduce, simply create a zip file from your results directory and pass that to the report generator.
| } | ||
| catch (IOException e) | ||
| { | ||
| System.err.println("Failed to walk file tree searching for custom data logs. Cause: " + e.getMessage()); |
There was a problem hiding this comment.
Don't print anything to the console. It will likely be overwritten by the progress bar updates anyway. If the error is tolerable or if it is just a debug message, write the information via a regular logger (e.g. XltLogger.runtime) to the log file. If the error is fatal, rethrow it wrapped inside an XltException for the report generator to handle that case.
Same for all other usages of System.err.println in this class.
No description provided.