[#323] Improvement: Enable passing credentials for Browserstack via environmental variables for better use in CI/CD #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oomelianchuk
force-pushed
the
#323-improvement-enable-passing-credentials-for-browserstack-via-environmental-variables-for-better-use-in-cicd
branch
from
ec45748 to
d638ef6
Compare
RobertAvemarg
approved these changes
Dec 16, 2024
wurzelkuchen
requested changes
Jan 13, 2025
| @@ -404,7 +404,7 @@ else if (safariBrowsers.contains(browserName)) | |||
| config.getGridProperties().put("userName", testEnvironmentProperties.getUsername()); | |||
| config.getGridProperties().put("accessKey", testEnvironmentProperties.getPassword()); | |||
| final String buildId = StringUtils.isBlank(System.getenv("BUILD_NUMBER")) ? "local run" : System.getenv("BUILD_NUMBER"); | |||
| config.getGridProperties().put("sessionName", testClassInstance.getClass().toString()); | |||
| config.getGridProperties().put("sessionName", testClassInstance instanceof String ? testClassInstance : testClassInstance.getClass().toString()); | |||
There was a problem hiding this comment.
Question @oomelianchuk this line has nothing to do with the ticket, but seems to be a bugfix? Or even more general, what is the testClassInstance? I checked and it is only called in one place where we hand over the test name.
So basically:
- would it make sense to just pass the testName as a string?
- the parameter is not part of the javaDoc, we need to change that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled reading of BROWSERSTACK_USERNAME and BROWSERSTACK_PASSWORD properties in case no value for test environment credentials were found in properties