Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parsing .xcode-version beta format #307

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Support parsing .xcode-version beta format #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e276646
Added support for parsing "b" as "beta" and added another assertion t…
Jul 10, 2023
b5d239f
Fix indentation by replacing tabs with spaces.
Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Sources/XcodesKit/Version+Xcode.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ public extension Version {

optionalPrereleaseIdentifiers[lastIndex] = "\(lastItem)-seed"
}
} else if type == "b" {
optionalPrereleaseIdentifiers.append("beta")
} else {
optionalPrereleaseIdentifiers.append(type)
}
Expand Down
4 changes: 4 additions & 0 deletions Tests/XcodesKitTests/Models+FirstWithVersionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ final class ModelsFirstWithVersionTests: XCTestCase {
installedXcodes.first(withVersion: Version(xcodeVersion: "1.2.3 Beta 2")!),
InstalledXcode(path: Path("/Applications/Xcode-1.2.3-beta.2.app")!, version: Version(xcodeVersion: "1.2.3 Beta 2")!)
)
XCTAssertEqual(
installedXcodes.first(withVersion: Version(xcodeVersion: "1.2.3b2")!),
InstalledXcode(path: Path("/Applications/Xcode-1.2.3-beta.2.app")!, version: Version(xcodeVersion: "1.2.3 Beta 2")!)
)

// With build metadata
XCTAssertEqual(
Expand Down