Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apple auth URLs #84

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

interstateone
Copy link
Contributor

The URLs we were using were originally from the xcode-install project and had been working up until today (2019/11/12). These URLs were updated in that project (actually in fastlane, which it uses for auth) about 7 months ago but I didn't notice this. I started to look in a web inspector while signing in to developer.apple.com and saw that the Olympus session URL changed. Dave DeLong noted that a slightly different URL worked for the iTC service key, which is also what xcinfo uses.

Testing

  1. Delete the com.robotsandpencils.xcodes keychain item
  2. swift run xcodes update should complete by printing out all the available Xcode versions which as of today should end with 11.2.1

Resolves #83

The URLs we were using were originally from the xcode-install project and had been working up until today (2019/11/12). These URLs were updated in that project (actually in fastlane, which it uses for auth) about 7 months ago but I didn't notice this. I started to look in a web inspector while signing in to developer.apple.com and saw that the Olympus session URL changed. Dave DeLong noted that a slightly different URL worked for the iTC service key, which is also what xcinfo uses.

fastlane/fastlane#14509
XcodesOrg#83 (comment)
https://github.com/xcodereleases/xcinfo/blob/e51f022db3584be884b5d10d8b161ac26dbbee0b/Sources/OlympUs/OlympUs.swift#L213
@MattKiazyk
Copy link
Contributor

Note: I didn't delete the keychain item before - but it did prompt me for keychain access again. After typing in my password nothing happened on the console. xcodes update then connected properly and printed out the correct versions.

9.4
9.4.1
10.0
10.1
10.2 (Installed)
10.2.1
10.3
11.0
11.1 GM Seed (11A1027) (Installed)
11.1
11.2
11.2.1

@MattKiazyk MattKiazyk self-requested a review November 13, 2019 16:58
@interstateone
Copy link
Contributor Author

Adding to the record from a side conversation: prompting for keychain access is expected sometimes, but not printing anything (error or list) is not expected. I can't reproduce locally right now but will note for a future fix.

@interstateone interstateone merged commit 01101fb into XcodesOrg:master Nov 13, 2019
@interstateone interstateone deleted the 83-update-auth-urls branch November 13, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple Developer authentication has changed
2 participants