Refactor to test and improve logging #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interstateone
force-pushed
the
34-improve-logging
branch
3 times, most recently
from
7a47ec6
to
d06ef68
Compare
interstateone
force-pushed
the
34-improve-logging
branch
from
7f1d15e
to
d71009e
Compare
The motivation for this is to be able to test more of the command implementations, and particularly logging during installation.
interstateone
force-pushed
the
34-improve-logging
branch
from
d71009e
to
867d0e4
Compare
The immediate motivation for this was that running tests was saving test data into my real configuration.json :)
interstateone
force-pushed
the
34-improve-logging
branch
from
867d0e4
to
060b5ea
Compare
MattKiazyk
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
Tested today with 11.3 - worked as intended.
(1/6) Downloading Xcode 11.3.0: 100%
(2/6) Unarchiving Xcode (This can take a while)
(3/6) Moving Xcode to /Applications/Xcode-11.3.0.app
(4/6) Moving Xcode archive Xcode-11.3.0.xip to the Trash
(5/6) Checking security assessment and code signing
(6/6) Finishing installation
xcodes requires superuser privileges in order to finish installation.
macOS User Password:
Xcode 11.3.0 has been installed to /Applications/Xcode-11.3.0.app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #34
The goal of this PR is to make it more clear to the user what xcodes is doing during the long-running install command. This is done by adding more console output explaining each step, with emphasis on the unarchiving step. Providing the current step number and total step count should provide a sense of overall progress.
In order to have some confidence in this new implementation and shorten the feedback loop when making changes, some refactoring was done that moved more code into the XcodesKit library target where it can be tested with the help of the Environment type.
Example happy-path output: