Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting Uncaught (in promise) error due to custom shortcuts #113

Closed
prem-k-r opened this issue Oct 23, 2024 · 7 comments
Closed

getting Uncaught (in promise) error due to custom shortcuts #113

prem-k-r opened this issue Oct 23, 2024 · 7 comments

Comments

@prem-k-r
Copy link
Collaborator

After creating a custom shortcut say https://chatgpt.com/ often after refreshed or opened new tab, some other functionality is not working. When check in developer tools, error was 'Uncaught (in promise)'
It behave correctly with default github repo link, but when edited to anything else..then this happens

reset the shortcut, fixes this issue

@prem-k-r
Copy link
Collaborator Author

image

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 3, 2024

Nope.
This results in not showing weather data properly.

@itz-rj-here
Copy link
Collaborator

itz-rj-here commented Nov 3, 2024

@prem-k-r is it fixed?

@itz-rj-here
Copy link
Collaborator

Nope. This results in not showing weather data properly.

hmm.

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 3, 2024

I checked v2.0, this error was there too.

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 4, 2024

@raphaelritz Could you please take a look at this?

When users add one or more custom shortcuts (besides the default GitHub repository link), after refreshing or opening a new tab, the weather data (Humidity, Feels Like, Location) fails to display. Upon inspecting the developer tools, the error noted is: "Uncaught (in promise)."

Resetting the shortcut resolves this issue. However, this workaround is inconvenient for users who are likely to add their own shortcuts.

As a temporary fix, I commented out code snippets related to FAVICON_CANDIDATES, which allows the Weather data to load. Unfortunately, for certain favicons, this results in lower-quality images.

@raphaelritz
Copy link
Contributor

On it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants