Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes and enhancements #107

Merged
merged 69 commits into from
Oct 27, 2024
Merged

Various Fixes and enhancements #107

merged 69 commits into from
Oct 27, 2024

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Oct 23, 2024

  • added padding in feelsLike
  • Czech date formatting
  • Changed margin of weather condition icon to position it for better appearing
  • pressing the "Enter" key on the keyboard in any input field(location, api, proxy) performs the same action as clicking the corresponding button.
    say we entered a location, to save it we click on "enter" button, now we can save by pressing enter key from Keyboard too.
  • userText placeholder text removal when the user starts editing and restore placeholder if the user leaves it empty after clicking, --> now works for all languages
  • fixed: When refreshed or new tab is opened, "Double Tap to Edit" shows briefly before loading
  • changed 'enter' to 'save' and 'search'
  • translated 'save' and 'search' in all lang
  • reordered language.js and script.js in index.html
  • added translation function for greeting with fallback to english
  • Translated greeting in all languages

Edit:
-Added Translation for menuCloseButton
-added translation for 'close' in all languages
with fallback to english if translation unavailable
-and some weather variable named

Edit2:
-Corrected some Czech transaltion with @ceskyDJ
-Bengali Numerals
alongwith option to add any other language numeral too

edit3:
-placeholder inputtext color
-Digital clock: display AM/PM when using 12 hr format
localised numerals and texts
date formatting
am/pm color

-Immediately date is updated when clock is analog

edit4:
-Replace decimal point with a comma for Czech
-Added a space before unit in Feelslike temperature in Czech
-changed "Enable/Disable" to "Show/Hide" for shortcuts and AI tools (in English only)

edt5:
-Fallback to English if any elements translation is missing (Earlier when any elements' translation is missing in all lang it shows eng but if it defined in even 1 lang then for other lang it was showing undefined, now with all the fallbacks it will show in English)
-locale am/pm

-Fixed: Weather Display issue when weatherCondition is long

-no leading zeros in hour for 12 hr format in digital clock, except in English and Italian

-Digital Clock: Hours in darker color and blinking colon

added padding in Seems
Update script.js for Czech date formatting
Changed margin of weather condition icon to position it for better appearing
pressing the "Enter" key on the keyboard in any input field performs the same action as clicking the corresponding button.
say we entered a location, to save it we click on "enter" button, now we can save by pressing enter key from Keyboard too.
userText placeholder text removal when the user starts editing and restore placeholder if the user leaves it empty after clicking, --> now works for all languages
userText placeholder text removal when the user starts editing and restore placeholder if the user leaves it empty after clicking, --> now works for all languages

+ fixed: When refreshed or new tab is opened, "Double Tap to Edit" shows briefly before loading
changed 'enter' to 'save' and 'search'
translated 'save' and 'search' in all lang
deleted wrong আপনার, fixed
reordered language.js and script.js
added translation function for greeting with fallback
Translated greeting in all languages
@prem-k-r
Copy link
Collaborator Author

@ceskyDJ

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 23, 2024

Czech has more day phases ("ráno", "dopoledne", "poledne", "odpoledne", "večer", "noc"), but I think this could be sufficient.

@prem-k-r
Copy link
Collaborator Author

@ceskyDJ 'Zavřiť' for close in menuCloseText
correct?

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 24, 2024

Almost, the correct one is "Zavřít“ (diacritical "i" and normal "t").

fixed Czech translation for close
@prem-k-r
Copy link
Collaborator Author

Almost, the correct one is "Zavřít“ (diacritical "i" and normal "t").

corrected, thanks

languages.js Show resolved Hide resolved
@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 24, 2024

corrected, thanks

You're welcome.

@itz-rj-here
Copy link
Collaborator

https://screenrec.com/share/G08aQb2hru

When I use a vpn and connect to uk ip, my weatherapi runs properly. But in my own ip the weatherapi sometimes doesn't able to give correct data and stays blank.

@prem-k-r
Copy link
Collaborator Author

  • position it for better appearing

It was appearing a bit off to me, one sided.
It is highlighted especially in clear night one

compressed.Recording.2024-10-26.184855.mp4

Is it not fine?

@prem-k-r
Copy link
Collaborator Author

https://screenrec.com/share/G08aQb2hru

When I use a vpn and connect to uk ip, my weatherapi runs properly. But in my own ip the weatherapi sometimes doesn't able to give correct data and stays blank.

huh, here no problem with display of Humidity, Feels, Earth
but weather icon not loading but loaded with vpn... can't understand reason
Try with a different API?

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 26, 2024

Try with a different API?

Maybe download images and serve them locally? Is it possible?

Digital Clock: Hours in darker color and blinking colon
Digital Clock: Hours in darker color and blinking colon
Digital Clock: Hours in darker color and blinking colon
@itz-rj-here
Copy link
Collaborator

https://screenrec.com/share/G08aQb2hru

When I use a vpn and connect to uk ip, my weatherapi runs properly. But in my own ip the weatherapi sometimes doesn't able to give correct data and stays blank.

huh, here no problem with display of Humidity, Feels, Earth
but weather icon not loading but loaded with vpn... can't understand reason
Try with a different API?

It happens cause the ip of the weatherapi takes time to connect with my ip.

@prem-k-r
Copy link
Collaborator Author

It happens cause the ip of the weatherapi takes time to connect with my ip.

if so then maybe other data also shouldn't have loaded

can you try deleting cookies and site data of weatherapi.com
image
then open new tab and press Ctrl + Shift + R

some revert back to check
changed twitter redirect link
Accurate °F
@prem-k-r
Copy link
Collaborator Author

@XengShi what is the error in the console?

checking 2
checking 3
checking 4
Reverted back the checkings
@prem-k-r
Copy link
Collaborator Author

@XengShi what is the error in the console?

Do you face the same issue in XengShi:main/v2.2, or is it working fine?

@itz-rj-here
Copy link
Collaborator

@XengShi what is the error in the console?

Do you face the same issue in XengShi:main/v2.2, or is it working fine?

https://screenrec.com/share/uPQ6t0fdAH
https://screenrec.com/share/fYztmTpOMo

@itz-rj-here
Copy link
Collaborator

I faced some issues here.

@itz-rj-here
Copy link
Collaborator

Also noticed that you have replaced the icon at little bit of downwards, which doesn't look good. Also ur weather icon has issue. Not on the original one as i noticed.

@itz-rj-here
Copy link
Collaborator

I think you should look on this and try to add some other weather api's too.
https://github.com/PranshulGG/WeatherMaster/tree/v1.7.4?tab=readme-ov-file#-weather-providers

@XengShi
Copy link
Owner

XengShi commented Oct 27, 2024

@prem12321kumar Today I rechecked it again, and everything works! not getting any error.

@XengShi XengShi merged commit 7cdf9f4 into XengShi:main Oct 27, 2024
@XengShi
Copy link
Owner

XengShi commented Oct 28, 2024

@XengShi what is the error in the console?

Do you face the same issue in XengShi:main/v2.2, or is it working fine?

[Windows 10, Chrome]
On the first reload or opening a new tab, it shows the location and 'Feels like' temperature for a few milliseconds, but then it goes back to displaying 'Earth' and 'Feels,' even though the temperature is shown correctly (in the pill-shaped widget).

Screenshot 2024-10-28 043052
image

@prem-k-r
Copy link
Collaborator Author

@XengShi what is the error in the console?

Do you face the same issue in XengShi:main/v2.2, or is it working fine?

[Windows 10, Chrome] On the first reload or opening a new tab, it shows the location and 'Feels like' temperature for a few milliseconds, but then it goes back to displaying 'Earth' and 'Feels,' even though the temperature is shown correctly (in the pill-shaped widget).

Screenshot 2024-10-28 043052 image

#113
Please try resetting shortcuts
IMG_20241028_102337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants