Optimized Weather stuff and More #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
prem-k-r
commented
Oct 28, 2024
•
prem-k-r
commented
- Reduced repetitive lookups of DOM elements
- Added try-catch block in ipinfo.io
- fetching from city instead of IP
- fallback to auto:ip if fetching fails.
- show fetched location in menu
- Repositioned weather icon
- Changed display of ° to °C or °F for temperature
- Fix: Menu close button's transition for longer text translated language(Hindi and Bengali)
- Changed order of AI tools shortcuts in menu
- Added toggle to show/hide UserTextBox
- Added toggle to show/hide Greeting in digital clock mode
- Changed some English texts and added translations in Hindi and Bengali based on what I felt was appropriate
check
|
Squash commits please |
Changed display of ° to °C or °F for temperature
|
|
itz-rj-here
approved these changes
Oct 29, 2024
Optimization
fix: Menu close button transition for longer text translated language(Hindi and Bengali)
Increased distance between theme and reset settings a little
Decreased search engine radio button size a little
Added toggle to hide User Text Box and Greeting
toggle to hide User Text Box and Greeting
changed some English texts and Hindi, Bangla translation
2 line ---> 1 line
|
Change the manifest newtab version to 2.3 too, as you made so many changes. |
|
Also can you download the weather icons and make it work when the weather icon doesn't loads? |
|
Ok I'll try to do tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.