-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Some Wrong Translated Language and Fixed some other issues. #127
Conversation
itz-rj-here
commented
Nov 2, 2024
•
edited
Loading
edited
- Changed line 320 in script.js "} else if (currentHour < 18) {" to "} else if (currentHour < 17) {".
- Removed additional text about using english on inputing location.
- Added a space on (Latitude, Longitude) in index.html and language.js.
Conflicts!!! |
Fixed |
Please change 18 to 17 in line 320 of script.js |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This missing space was intentional, as latitude,longitude is typically written without a space. In the WeatherAPI parameter, using no space is preferred, although it still works correctly with a space.
I can understand but adding space would look better. Thats way i added a space. |
Can you please confirm if ইংরেজিতে আপনার শহর বা স্থানাঙ্ক (অক্ষাংশ, দ্রাঘিমাংশ) fits in the input area.. is it fully visible. |
I think we should say about writing in english in the "Enter your Location" like "Enter your Location (In English)" |
In English, I think, we can leave as it is. For most languages that follows Latin/Roman characters people write in English. But not for Bangla, Hindi, Russian,etc. |
On it. |