Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Some Wrong Translated Language and Fixed some other issues. #127

Merged
merged 5 commits into from
Nov 2, 2024

Conversation

itz-rj-here
Copy link
Collaborator

@itz-rj-here itz-rj-here commented Nov 2, 2024

  • Changed line 320 in script.js "} else if (currentHour < 18) {" to "} else if (currentHour < 17) {".
  • Removed additional text about using english on inputing location.
  • Added a space on (Latitude, Longitude) in index.html and language.js.

@XengShi
Copy link
Owner

XengShi commented Nov 2, 2024

Conflicts!!!

@itz-rj-here
Copy link
Collaborator Author

Conflicts!!!

Fixed

@itz-rj-here
Copy link
Collaborator Author

@XengShi

@prem-k-r
Copy link
Collaborator

prem-k-r commented Nov 2, 2024

Add Good Noon greeting for 12 pm to 5 pm time.

Please change 18 to 17 in line 320 of script.js

@itz-rj-here
Copy link
Collaborator Author

Add Good Noon greeting for 12 pm to 5 pm time.

Please change 18 to 17 in line 320 of script.js

Done.

Copy link
Collaborator

@prem-k-r prem-k-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This missing space was intentional, as latitude,longitude is typically written without a space. In the WeatherAPI parameter, using no space is preferred, although it still works correctly with a space.

@itz-rj-here
Copy link
Collaborator Author

This missing space was intentional, as latitude,longitude is typically written without a space. In the WeatherAPI parameter, using no space is preferred, although it still works correctly with a space.

I can understand but adding space would look better. Thats way i added a space.

@prem-k-r
Copy link
Collaborator

prem-k-r commented Nov 2, 2024

Can you please confirm if ইংরেজিতে আপনার শহর বা স্থানাঙ্ক (অক্ষাংশ, দ্রাঘিমাংশ) fits in the input area.. is it fully visible.

@itz-rj-here
Copy link
Collaborator Author

Can you please confirm if ইংরেজিতে আপনার শহর বা স্থানাঙ্ক (অক্ষাংশ, দ্রাঘিমাংশ) fits in the input area.. is it fully visible.

image
Huh that doesn't looks good.

@itz-rj-here
Copy link
Collaborator Author

itz-rj-here commented Nov 2, 2024

I think we should say about writing in english in the "Enter your Location" like "Enter your Location (In English)"
What do you prefier? @prem12321kumar
Or just remove the "ইংরেজিতে".

@prem-k-r
Copy link
Collaborator

prem-k-r commented Nov 2, 2024

I think we should say about writing in english in the "Enter your Location" like "Enter your Location (In English)" What do you prefier? @prem12321kumar Or just remove the "ইংরেজিতে".

In English, I think, we can leave as it is. For most languages that follows Latin/Roman characters people write in English. But not for Bangla, Hindi, Russian,etc.
Let's go with removing ইংরেজিতে for now
Also could you please remove ", English में" from Hindi too, line 276.

@itz-rj-here
Copy link
Collaborator Author

I think we should say about writing in english in the "Enter your Location" like "Enter your Location (In English)" What do you prefier? @prem12321kumar Or just remove the "ইংরেজিতে".

In English, I think, we can leave as it is. For most languages that follows Latin/Roman characters people write in English. But not for Bangla, Hindi, Russia,etc. Let's go with removing ইংরেজিতে for now Also could you please remove ", English में" from Hindi too

On it.

@itz-rj-here itz-rj-here requested a review from prem-k-r November 2, 2024 12:38
@itz-rj-here itz-rj-here changed the title Fixed Some Wrong Translated Language in Bengali. Fixed Some Wrong Translated Language and Fixed some other issues. Nov 2, 2024
@XengShi XengShi merged commit 2487fb8 into XengShi:main Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants