Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed color of theme color option in the menu #144

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Nov 5, 2024

This PR is subject to review and discussion, please check #140

Existing:
image

Changed to:
IMG_20241105_142034

Edited second image to avoid confusion

@XengShi XengShi merged commit 4febe36 into XengShi:main Nov 5, 2024
@XengShi
Copy link
Owner

XengShi commented Nov 5, 2024

I can't believe, I just (few hours ago) thought about the exact same thing (adding two dark mode options).

@XengShi
Copy link
Owner

XengShi commented Nov 5, 2024

image

I am not getting two dark mode buttons

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 5, 2024

I can't believe, I just (few hours ago) thought about the exact same thing (adding two dark mode options).

What about other color change.. overall it doesn't looks that good as before

@itz-rj-here
Copy link
Collaborator

Bro i just came from school. My exam went really well.

@itz-rj-here
Copy link
Collaborator

Literally very well.

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 5, 2024

image

I am not getting two dark mode buttons

It is in #130, if I add now, it will show all white when that theme selected

@itz-rj-here
Copy link
Collaborator

image
I am not getting two dark mode buttons

It is in #130, if I add now, it will show all white when that theme selected

I see. let me then update my extention.

@XengShi
Copy link
Owner

XengShi commented Nov 5, 2024

image
I am not getting two dark mode buttons

It is in #130, if I add now, it will show all white when that theme selected

Okay, having two dark variant full black and greyish would be great, and can you modify yellow theme which currently looks ugly

@XengShi
Copy link
Owner

XengShi commented Nov 5, 2024

Old
image

New :
image

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 5, 2024

image
I am not getting two dark mode buttons

It is in #130, if I add now, it will show all white when that theme selected

Okay, having two dark variant full black and greyish would be great, and can you modify yellow theme which currently looks ugly

I copied these color codes from theme
I'll change it as you want

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 5, 2024

Old image

New : image

Ah wait.. i didn't noticed this.. I didn't mean this.. I'll check..
For now let's revert back this PR

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 5, 2024

Old image

New : image

that's odd,
Nothing changed at https://xengshi.github.io/materialYouNewTab/
image

@itz-rj-here
Copy link
Collaborator

Old image
New : image

that's odd, Nothing changed at https://xengshi.github.io/materialYouNewTab/ image

Bruh what you guys are mean to say? The color code you changed is for the menu option only. It will not change the main theme tho. Unless you change something on the theme code.

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 5, 2024

Exactly

@itz-rj-here
Copy link
Collaborator

Exactly

can you review this #146

@XengShi
Copy link
Owner

XengShi commented Nov 5, 2024

Old image
New : image

that's odd, Nothing changed at https://xengshi.github.io/materialYouNewTab/ image

Bruh what you guys are mean to say? The color code you changed is for the menu option only. It will not change the main theme tho. Unless you change something on the theme code.

I just gave him a hint of the new yellow theme by temporarily changing the color using inspect element.

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 5, 2024

Old image
New : image

that's odd, Nothing changed at https://xengshi.github.io/materialYouNewTab/ image

Bruh what you guys are mean to say? The color code you changed is for the menu option only. It will not change the main theme tho. Unless you change something on the theme code.

I just gave him a hint of the new yellow theme by temporarily changing the color using inspect element.

Oh lol.. So it was a misunderstanding.

Btw, what about Cyan theme. This is the only theme I don't like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants