Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the search bar text input area and added toggle to hide mic icon #185

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Fixed the search bar text input area and added toggle to hide mic icon #185

merged 8 commits into from
Nov 15, 2024

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Nov 13, 2024 •
edited
Loading

Closes #181

  • Searchbar Text Input area width now dynamically adapt, in all languages, wrt mic and search button
  • Cursor type no longer change to Text on Search Icon
    .

Added toggle to hide mic icon

  • Set the initial state of the mic icon visibility and checkbox based on supported browser
    (Hid the mic icon in the Brave browser too)
  • Translated same

@prem-k-r
Copy link
Collaborator Author

@XengShi let's go for v2.4?

@itz-rj-here
Copy link
Collaborator

@XengShi let's go for v2.4?

Yes please. :)

@prem-k-r
Update script.js
b58b27e 
Deleted duplicate
@prem-k-r
Update script.js
3b2fc8a 
Hide mic icon in brave
@prem-k-r prem-k-r changed the title Fixed Searchbar Text Input area Fixed Searchbar Text Input area and Mic Icon hided in Brave browser Nov 14, 2024
@prem-k-r prem-k-r changed the title Fixed Searchbar Text Input area and Mic Icon hided in Brave browser Fixed the search bar text input area and hid the mic icon in the Brave browser Nov 14, 2024
@prem-k-r prem-k-r marked this pull request as draft November 14, 2024 19:42
@prem-k-r prem-k-r changed the title Fixed the search bar text input area and hid the mic icon in the Brave browser Fixed the search bar text input area and added toggle to hide mic icon Nov 14, 2024
@prem-k-r prem-k-r marked this pull request as ready for review November 14, 2024 20:05
@XengShi XengShi merged commit bb2d5e1 into XengShi:main Nov 15, 2024
@prem-k-r prem-k-r deleted the patch-1 branch November 15, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need fix: Searchbar Text Input area is fixed
3 participants
@prem-k-r @itz-rj-here @XengShi