Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated Missing Elements in Some Languages #187

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Nov 15, 2024

Earlier, I used machine translation (MTL) as there was no English fallback, which resulted "Undefined" to appear instead.
Now there’s an English fallback, but it looks odd with English text mixed into languages like Chinese.

It's been a while, and translations are still pending.
So, MTLed for now until people can improve them later.

Other changes:
menuWidth increased and fixed typo of Celsius in Italian

@prem-k-r
Copy link
Collaborator Author

@ceskyDJ new strings

"micIconTitle": "Hide Microphone Icon",
"micIconInfo": "If voice search isn't working in your browser",

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Nov 15, 2024

@ceskyDJ new strings

"micIconTitle": "Hide Microphone Icon",
"micIconInfo": "If voice search isn't working in your browser",

Thanks ❤️! You can use this translation:

- "micIconTitle": "Hide Microphone Icon",
- "micIconInfo": "If voice search isn't working in your browser",
+ "micIconTitle": "Skrýt ikonu mikrofonu",
+ "micIconInfo": "Pokud ve vašem prohlížeči nefunguje hlasové vyhledávání",

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Nov 15, 2024

It's been a while, and translations are still pending.
So, MTLed for now until people can improve them later.
@prem-k-r, could you please mark these strings somehow? I think a comment could be sufficient. E.g.:

 "micIconTitle": "Some machine translation…", // Machine translated

Co-authored-by: ceskyDJ <48548230+ceskyDJ@users.noreply.github.com>
@prem-k-r
Copy link
Collaborator Author

@ceskyDJ new strings
"micIconTitle": "Hide Microphone Icon",
"micIconInfo": "If voice search isn't working in your browser",

Thanks ❤️! You can use this translation:

- "micIconTitle": "Hide Microphone Icon",
- "micIconInfo": "If voice search isn't working in your browser",
+ "micIconTitle": "Skrýt ikonu mikrofonu",
+ "micIconInfo": "Pokud ve vašem prohlížeči nefunguje hlasové vyhledávání",

done, but see gap
image

change to following?
image
or leave it?
or increase menu width? (have to increase by lot, initial toggles' text are shorter in length, so it doen't look good)

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Nov 15, 2024

@ceskyDJ new strings
"micIconTitle": "Hide Microphone Icon",
"micIconInfo": "If voice search isn't working in your browser",

Thanks ❤️! You can use this translation:

- "micIconTitle": "Hide Microphone Icon",
- "micIconInfo": "If voice search isn't working in your browser",
+ "micIconTitle": "Skrýt ikonu mikrofonu",
+ "micIconInfo": "Pokud ve vašem prohlížeči nefunguje hlasové vyhledávání",

done, but see gap
image

change to following?
image
or leave it?
or increase menu width? (have to increase by lot, initial toggles' text are shorter in length, so it doen't look good)

You can shrink it, as you proposed. When speaking of the menu width… Could you please increase it a bit? As you see, this problem is with more comfig options.

Btw, what about shortening the English version, too? I think the information about browser is redundant.

Co-authored-by: ceskyDJ <48548230+ceskyDJ@users.noreply.github.com>
@prem-k-r
Copy link
Collaborator Author

Btw, what about shortening the English version, too? I think the information about browser is redundant.

I thought about it too, XengShi proposed it, it gives a hint that it's a browser problem and may work in other browsers, so I left it.

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 15, 2024

When speaking of the menu width… Could you please increase it a bit? As you see, this problem is with more comfig options.

to this?
image
image

@XengShi
Copy link
Owner

XengShi commented Nov 15, 2024

Btw, what about shortening the English version, too? I think the information about browser is redundant.

I thought about it too, XengShi proposed it, it gives a hint that it's a browser problem and may work in other browsers, so I left it.

You can add 'learn more' like button and show information to user like

'Voice search is currently working in only [supported-browser] due to [xyz-reason] '

@prem-k-r
Copy link
Collaborator Author

Btw, what about shortening the English version, too? I think the information about browser is redundant.

I thought about it too, XengShi proposed it, it gives a hint that it's a browser problem and may work in other browsers, so I left it.

You can add 'learn more' like button and show information to user like

'Voice search is currently working in only [supported-browser] due to [xyz-reason] '

um, how about a disclaimer-type message, similar to the one displayed when proxy is turned on?

@prem-k-r
Copy link
Collaborator Author

I'll check it later,

changed

-"If voice search isn't working in your browser"
+"If voice typing is not working"

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Nov 15, 2024

When speaking of the menu width… Could you please increase it a bit? As you see, this problem is with more comfig options.

to this? image image

It looks good to me.

@prem-k-r
Copy link
Collaborator Author

ok, just a sec

@XengShi XengShi merged commit 238f04b into XengShi:main Nov 15, 2024
@prem-k-r prem-k-r deleted the patch-3 branch November 15, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants