-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better quality Github shortcut logo #193
Conversation
Github logo link
It would be better if you use svg code :) |
This comment was marked as outdated.
This comment was marked as outdated.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :)
I don't think we need that |
System will check unnecessarily [ if (hostname === "github.com") ] for every website |
Is that so? This is for shortcut icon, not the website favicon though |
When a new tab opens or a page refreshes, it fetches the shortcut icons from the web each time. I believe a simple if statement shouldn't be a significant burden. |
Instead, it's a good thing as it skips fetching from the web if the domain is github.com, allowing it to work offline as well. Isn't? |
yeah |
Can we get the new release :)? |
OK then, I may misunderstood. |
to