-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Arrow Key Selection of Search Suggestion #202
Conversation
@XengShi Can you check if this works on other browsers until I try to fix the bg color please :o |
Bruh chatgpt also giving wrong suggestion.
|
Any ideas guys? |
@prem-k-r can you atleast help me on this selection color issue please 🥺 |
wait, i am checking the code in my pc |
ok done, i'll raise pr for it meanwhile, there is an issue, after visible result( first 5) it is not shifting/scrolling.. it is moving up/down but not visible |
Ok let me look into it too. |
Also we have to see if mouse cursor is within resultBox, then keyboard selection must be unhighlighted |
I noticed one more bug. Hint : |
Bruh It's not ready for review. |
Someone of you need to fix the highlight thingy when we will let this pr to be merged. |
I will check tomorrow 💤😴 |
I accidentally touched that button 🙃 don't know how to ctrl+z |
The fold/unfold(little up/down arrow) botton might be affecting it. |
Rest of the things seems okay to me. |
if mouse cursor is within resultBox, then keyboard selection is unhighlighted
okay, done this too. |
Coloring in Search Suggestion when accessing through keyboard and some visual changes on resultBox
Check the chrome search bar. Use the pointer to hover and use the arrow key to highlight. We need to setup it like that. |
Main thing is we need to make it like 2 text will be highlighten when selecting a text from search suggestion. |
Shouldn't having 2 highlighted text. Have to choose one. Prioritising mouse cursor over keyboard. |
decreasing gap between searchbar and suggestion box
decreasing gap between searchbar and suggestion box
decreasing gap between searchbar and suggestion box Co-authored-by: prem-k-r <60751338+prem-k-r@users.noreply.github.com>
@ceskyDJ r u alive bruh 🗿? |
I'm sorry, I'm just too busy with school. I think it's not that bad. I'd personally append the suggestion list just under the search input and don't use so big |
If we align it with search text, it doesn't looks good, background For |
No need I just came home and checked it one more time. It is looking way better than before. |
|
I like this one more, |
Okayee do that. |
Yes, search suggestions width = searchbar's width is looking better |
yeah, but what about border radius, @ceskyDJ asked for smaller radius |
Just use one which matches perfectly with other elements of extension. |
Ok |
Closes #183
Bug fix requested by @ceskyDJ
There is still a issue. I can't able to understand how can I use the same bg color of pointer hover color and the arrow key selection color.
Here is the screenshot of the issue:-
Need some help on fixing this issue.