Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to Google apps #205

Merged
merged 16 commits into from
Nov 25, 2024
Merged

Changes related to Google apps #205

merged 16 commits into from
Nov 25, 2024

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Nov 22, 2024

Closes #207

  • Added 2 more shortcuts
    • filled this spaced
      image

after:
image
image

Google apps icon edited
@prem-k-r
Copy link
Collaborator Author

Btw, how about adding bg too behind 9-dots?

like this or something similar:
image
image

@prem-k-r
Copy link
Collaborator Author

Changed Shopping icon too
image
to
image

resized photos
rearranged youtube
changed maps icon
@prem-k-r
Copy link
Collaborator Author

Changed Maps
image
to
image

@itz-rj-here
Copy link
Collaborator

Btw, how about adding bg too behind 9-dots?

like this or something similar:
image
image

What does the animation look like when hovering into it?

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 22, 2024

Btw, how about adding bg too behind 9-dots?
like this or something similar:
image

What does the animation look like when hovering into it?

Recording.2024-11-22.211542.mp4

https://github.com/user-attachments/assets/e6115d51-918b-4bac-8048-5cd105c74e0b
I'm not sure, having mixed feeling, so haven't implemented. On hover, scaling haven't applied yet

@itz-rj-here
Copy link
Collaborator

Btw, how about adding bg too behind 9-dots?
like this or something similar:
image

What does the animation look like when hovering into it?

Recording.2024-11-22.211542.mp4
https://github.com/user-attachments/assets/e6115d51-918b-4bac-8048-5cd105c74e0b I'm not sure, having mixed feeling, so haven't implemented. On hover, scaling haven't applied yet

add the bg with the animation it doesn't looks good without it. Or we have to revove the animation.

@prem-k-r
Copy link
Collaborator Author

Btw, how about adding bg too behind 9-dots?

I'm not sure, having mixed feeling, so haven't implemented. On hover, scaling haven't applied yet

add the bg with the animation it doesn't looks good without it. Or we have to revove the animation.

9.dot.bg.mp4

doesn't fit perfectly either.

I just want to say that 9-dots doesn't getting along with other UI

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 22, 2024

How about this?
image
image

fixed responsiveness of 9-dot icon
@itz-rj-here
Copy link
Collaborator

My brain is not working 🙂
Ask @XengShi

Replaced Gemini with YTMusic
@prem-k-r
Copy link
Collaborator Author

image
Added YTMusic

@itz-rj-here
Copy link
Collaborator

The YTMusic Name Doesn't looks good to me. Why you don't use the label short one and label full class and see how it looks. If it looks better than we are good to go with it.

@itz-rj-here
Copy link
Collaborator

@XengShi Why you don't reply to him and say that we are going to add a new option for google apps where he will find a ytmusic option on there.

@itz-rj-here
Copy link
Collaborator

What? How?
The Container should have placed on a fixed position. Why it's shifting?

https://screenrec.com/share/XuvkfcM7UB

@prem-k-r
Copy link
Collaborator Author

The YTMusic Name Doesn't looks good to me. Why you don't use the label short one and label full class and see how it looks. If it looks better than we are good to go with it.

doesn't look good

ytmusic.mp4

@itz-rj-here
Copy link
Collaborator

itz-rj-here commented Nov 23, 2024

The YTMusic Name Doesn't looks good to me. Why you don't use the label short one and label full class and see how it looks. If it looks better than we are good to go with it.

doesn't look good

ytmusic.mp4

Uhh idk why its shifting on my one. Anyways, Then Add one space on the name like this "YT Music"
Then leave the pr to be merged.

@itz-rj-here
Copy link
Collaborator

Cause it doesn't looks good to me when the name has no space.

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 23, 2024

The YTMusic Name Doesn't looks good to me. Why you don't use the label short one and label full class and see how it looks. If it looks better than we are good to go with it.

doesn't look good
ytmusic.mp4

Uhh idk why its shifting on my one. Anyways, Then Add one space on the name like this "YT Music" Then leave the pr to be merged.

probably shifting svg 1px up may solve ur shifting or you have not added break

@prem-k-r
Copy link
Collaborator Author

Cause it doesn't looks good to me when the name has no space.

ok adding space

Added space in YTMusic
Copy link
Collaborator

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to Go

@itz-rj-here
Copy link
Collaborator

@prem-k-r use the Closes message here for #207

@itz-rj-here
Copy link
Collaborator

Closes #207

@itz-rj-here
Copy link
Collaborator

Closes #207

Okay I am not be able to add the Closes message here :)

@prem-k-r prem-k-r marked this pull request as draft November 25, 2024 11:21
@prem-k-r prem-k-r changed the title More Google apps icon added Changes related to Google apps Nov 25, 2024
@prem-k-r prem-k-r marked this pull request as ready for review November 25, 2024 11:34
@XengShi XengShi merged commit f6c295b into XengShi:main Nov 25, 2024
@prem-k-r prem-k-r deleted the patch-2 branch November 25, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - Adding YT Music on shortcuts
3 participants