-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Issue with Search Bar #209
Conversation
if mouse cursor is within resultBox, then keyboard selection is unhighlighted
Coloring in Search Suggestion when accessing through keyboard and some visual changes on resultBox
Co-authored-by: prem-k-r <60751338+prem-k-r@users.noreply.github.com>
decreasing gap between searchbar and suggestion box
decreasing gap between searchbar and suggestion box
decreasing gap between searchbar and suggestion box Co-authored-by: prem-k-r <60751338+prem-k-r@users.noreply.github.com>
- Removed Useless comment and space It's actually not possible it to add focus on the extention's search bar cause chrome defaultly focuses to their search bar.
Co-Authored-By: Prem Kumar <60751338+prem-k-r@users.noreply.github.com>
@prem-k-r Added outline color as you requested. Now review it bruh. -_- |
Sorry accidently clicked on the close button :) |
@prem-k-r have you checked it still? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seems to working correctly.
I can see it works |
Uhh I understand but chrome defaultly uses the focus for their search bar thats way it shows like this. |
I know, but that's not the problem. What happening after adding code
|
Hmm. Need to think more deeper. Let me try to fix it. |
I found a useless idea from gpt for the first time. GPT gave me this extention to make it focus. https://chromewebstore.google.com/detail/search-box-focus/amgmdnojamodmpfjaokfgpijhpcednjm |
check out their github, if we can implement what we wants from it |
I already tried it. I don't still see any solution for this. What you think? If you agree i will close this pr. |
ok |
When clicking on the Search Bar 2 times the outline of the Search Bar goes invisible. Now it's fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
When clicking on the Search Bar 2 times the outline of the Search Bar goes invisible. Now it's fixed.