Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP for URL in Shortcuts and Offline Favicon #226

Merged
merged 7 commits into from
Nov 30, 2024

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Nov 29, 2024

http support

and image loading error on offline scenario
image
to
image

@prem-k-r prem-k-r changed the title Support HTTP for URL in Shortcuts Support HTTP for URL in Shortcuts and Offline Favicon Nov 29, 2024
@prem-k-r prem-k-r marked this pull request as ready for review November 29, 2024 11:26
@prem-k-r
Copy link
Collaborator Author

I also wanted to fix error when there is an invalid url for shortcut. but unable to do it.

@prem-k-r prem-k-r marked this pull request as draft November 29, 2024 12:22
Rescaled to 90%
@prem-k-r prem-k-r marked this pull request as ready for review November 29, 2024 12:41
@XengShi
Copy link
Owner

XengShi commented Nov 29, 2024

SHould I merge it now?

@prem-k-r
Copy link
Collaborator Author

yes, thanks

@itz-rj-here
Copy link
Collaborator

SHould I merge it now?

Yup.

@itz-rj-here itz-rj-here mentioned this pull request Nov 30, 2024
changed svg
@prem-k-r
Copy link
Collaborator Author

changed svg
image
to
image

changed svg color
@prem-k-r
Copy link
Collaborator Author

chaged color too
image

image

@XengShi XengShi merged commit fcf5fd3 into XengShi:main Nov 30, 2024
@prem-k-r prem-k-r deleted the patch-2 branch November 30, 2024 12:20
@prem-k-r prem-k-r restored the patch-2 branch November 30, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants