Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Scrollbar When Shortcuts Overflow #228

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

prem-k-r
Copy link
Collaborator

No description provided.

@itz-rj-here
Copy link
Collaborator

Before
image

After
image

@itz-rj-here
Copy link
Collaborator

No rolling animation?
image

@prem-k-r
Copy link
Collaborator Author

No rolling animation? image

XengShi did. tbh I like this one. last one tilt 10° 😵

@itz-rj-here
Copy link
Collaborator

No rolling animation? image

XengShi did. tbh I like this one. last one tilt 10° 😵

Agreed. It's actually better than the old one.

@prem-k-r
Copy link
Collaborator Author

Before [image]

After [image]

It didn't look good to me, plus it was visible in the menu too. Also, clicking on 'AI Tools' hid the scrollbar and shifted the entire screen.

@itz-rj-here
Copy link
Collaborator

@prem-k-r can you now do the language dropdown thingy.

@prem-k-r
Copy link
Collaborator Author

@prem-k-r can you now do the language dropdown thingy.

ok

@itz-rj-here
Copy link
Collaborator

Before [image]
After [image]

It didn't look good to me, plus it was visible in the menu too. Also, clicking on 'AI Tools' hid the scrollbar and shifted the entire screen.

Saw that. Just added the ss for @XengShi.

@XengShi
Copy link
Owner

XengShi commented Nov 29, 2024

Before [image]
After [image]

It didn't look good to me, plus it was visible in the menu too. Also, clicking on 'AI Tools' hid the scrollbar and shifted the entire screen.

Saw that. Just added the ss for @XengShi.

Thanks

@XengShi
Copy link
Owner

XengShi commented Nov 29, 2024

@prem-k-r @itz-rj-here
I hope you test the extension on Chrome and Firefox before submitting a pull request.

Before merging any PR, I personally test the extension on both browsers. If you’re already testing it beforehand, please let me know so I can review and merge your changes more quickly.

@prem-k-r
Copy link
Collaborator Author

I have tested this one on chrome, edge, firefox and brave

@prem-k-r
Copy link
Collaborator Author

@prem-k-r @itz-rj-here I hope you test the extension on Chrome and Firefox before submitting a pull request.

Before merging any PR, I personally test the extension on both browsers. If you’re already testing it beforehand, please let me know so I can review and merge your changes more quickly.

ok noted

@itz-rj-here
Copy link
Collaborator

@prem-k-r @itz-rj-here
I hope you test the extension on Chrome and Firefox before submitting a pull request.

Before merging any PR, I personally test the extension on both browsers. If you’re already testing it beforehand, please let me know so I can review and merge your changes more quickly.

Uhhh. For now i just tested it on chrome. Idk about the firefox. But as you said i will do that from now on.

@itz-rj-here
Copy link
Collaborator

@prem-k-r remind me to mention when the language thingy is done.

@XengShi XengShi merged commit f25e51d into XengShi:main Nov 29, 2024
@XengShi
Copy link
Owner

XengShi commented Nov 29, 2024

@prem-k-r @itz-rj-here
I hope you test the extension on Chrome and Firefox before submitting a pull request.

Before merging any PR, I personally test the extension on both browsers. If you’re already testing it beforehand, please let me know so I can review and merge your changes more quickly.

Uhhh. For now i just tested it on chrome. Idk about the firefox. But as you said i will do that from now on.

Yup, because some visual changes look different in Firefox 🙃

@itz-rj-here
Copy link
Collaborator

@prem-k-r @itz-rj-here
I hope you test the extension on Chrome and Firefox before submitting a pull request.

Before merging any PR, I personally test the extension on both browsers. If you’re already testing it beforehand, please let me know so I can review and merge your changes more quickly.

Uhhh. For now i just tested it on chrome. Idk about the firefox. But as you said i will do that from now on.

Yup, because some visual changes look different in Firefox 🙃

Yup cuz it's not chromium based 🙂

@prem-k-r prem-k-r deleted the patch-3 branch November 29, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants