-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Feature/search engine selection #257
Adding Feature/search engine selection #257
Conversation
princevora
commented
Dec 2, 2024
•
edited
Loading
edited
- Added DropDown Support With all the supported search engine In the materialYouNewTab.
- The DropDown Supports all the colors which are currently active as it has used the pre written css classes and styles.
- The Feature has short code and i have focused on clean and readable code
- The Dropdown stores the selected search engine in the local storage same as the radio button does.
- It will automatically detect and select the appropriate search engine from local storage when ever the new tab is been created.
This Fork Has all the recent code and added a feature to enable or disable the shortcut search. |
if you don't have any problem can you place the type here... Text little bit of right side please... |
Your code works well overall, but I noticed a couple of minor issues that could be improved: Screencast.From.2024-12-02.13-16-05.mp4Upon reloading the page, the radio button momentarily appears for a fraction of a second before disappearing. Screencast.From.2024-12-02.13-17-37.mp4On the first load of the extension, both options—'Search with' and 'Dropdown selection'—are enabled simultaneously, whereas initially, only the 'Search with' option should be active. |
i can feel that the position of the icon's doesn't looks good. |
I recently learned that we can use the element. It allows us to reference an SVG symbol, avoiding the need to write the same SVG code repeatedly and making our code cleaner. example:
I'm not sure if we can do the same here, but you can check if it's possible. |
i updated it, it should be good now. |
index.html
Outdated
@@ -563,7 +656,7 @@ | |||
<!-- ----------end of searchbar-------------- --> | |||
|
|||
<!-- ----------search with------------------- --> | |||
<div class="searchWithCont"> | |||
<div class="searchWithCont" style="visibility: hidden;;" id="search-with-container"> |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I suggest if toggle is on then shift |
I have updated your suggestions you told me |
Ohh i see |
I have added the default as search with option |
i hope its all good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah sorry,
toggle on -> after reloading page, toggle got off
state not saving
It was calling the function before initializing the html values, its fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
I just realised a case.. search engine dropdown menu should hide automatically when resultBox from search suggestions pops up |
done |