Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

life count down function added with ui #265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abhimanyupayasi
Copy link

life count down function added with html & style : css | changes only on JS, HTML , CSS | the function & ui just do2 things take input on calender & output the remind time that user have

first user save input of hit age or any task

image

After this thay can see their task timing & manage their work with time

image

Abhimanyu Payasi
abhimanyupayasi01@gmail.com

@itz-rj-here
Copy link
Collaborator

itz-rj-here commented Dec 4, 2024

image
image
image

  1. Not appropriate with other color theme's. The container color is the same when changing other color's.
  2. Needed translation to the timer.
  3. Once the timer is set, there is no way to change it again.
  4. The writing text area is too much big. Need to decrease the text writing area.
  5. No option to turn this feature off in menu container.
  6. Doesn't looks good with the UI.

Copy link
Collaborator

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting more modification and changes
@prem-k-r

@@ -465,6 +466,19 @@
<div id="userText" contenteditable="true" spellcheck="false">Click here to edit</div>
<div id="date"></div>
</div>

<div id="death-date-container" style="overflow: hidden;">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Death Container 💀

@prem-k-r
Copy link
Collaborator

prem-k-r commented Dec 4, 2024

Great work.
Responsiveness and toggle also need to be added.
I'm not sure if we should be adding this.
Let's get confirmation from XengShi first if we are going with the idea.

@Abhimanyupayasi
Copy link
Author

Sure Let's give me confirmation from that we are going with the idea. if you will agree then I will create a new PR Request with all the feature.
Thank you

@itz-rj-here
Copy link
Collaborator

@XengShi Can you please review this feature?...

@XengShi
Copy link
Owner

XengShi commented Dec 4, 2024

Sure Let's give me confirmation from that we are going with the idea. if you will agree then I will create a new PR Request with all the feature.
Thank you

Your idea and feature is fantastic! To ensure a seamless experience, please align the UI with the existing design elements of the extension for consistency and a polished look. Once you achieve this, feel free to proceed.

Please make sure the feature is disabled by default and include an option in the settings menu to enable it. Lastly, Kindly follow the guidelines specified in the https://github.com/XengShi/materialYouNewTab/blob/main/CONTRIBUTING.md file.

@Abhimanyupayasi
Copy link
Author

ok thank you , after achieving the ui i will commit

@itz-rj-here itz-rj-here added the changes required PR requires updates based on review feedback label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required PR requires updates based on review feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants