Fix issue when a invalid url is entered in shortcut link #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invalid url check and direct to a page, and icon
|
There is a still an issue in original code ... when user enter a valid website link but having NO (or blocked) favicon |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to fix without changing custom Shortcuts code
this can be a workaround till someone fixes flaws in the shortcuts code
Added a url check, if invalid, github page url will be saved, user will see below page and icon
this will fix issues like.. error on console.. weather data not showing coz of that.. shortcut keep coming back even after deleted and had to reset to remove it
this doesn't do anything if an entered website doesn't exist