Dark Mode for All Existing Color Themes

[Thunder-Blaze]

📝 Description

Added Dark mode for all the colors

📸 Screenshots / 📹 Videos

🔗 Related Issues

• Closes Dark theme toggle on custom color #419

✅ Checklist

• I have read and followed the Contributing Guidelines.
• I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
• I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
• Attached visual evidence of changes (screenshots or videos) if applicable.

[Thunder-Blaze]

Fixed the issue ig

[itz-rj-here]

Great work. We need to check for every issues we find here..

[Thunder-Blaze]

Great work. We need to check for every issues we find here..

I think there is one issue, that screen blinking one when dark mode is on (we might need to put the logic in preload.js)
other than that lmk if you encounter any issues

[prem-k-r]

what it look like for black(dark) theme?

[Thunder-Blaze]

what it look like for black(dark) theme?

lol

hehe

wait a min ig I can fix this

[prem-k-r]

we can ignore any changes if it's black theme

[Thunder-Blaze]

we can ignore any changes if it's black theme

yes, done :)

[prem-k-r]

Is color palette still white?

[Thunder-Blaze]

Nope it should be black now I think

[prem-k-r]

Ok, nice

[prem-k-r]

Great work!
some of the themes looks ugly.. cant be helped ig

Is it possible to use #1d1d1d instead of #000, too much constrast for black parts

can you please exclude bookmarks favicons from color inverting

[prem-k-r]

And the preload bg color is still previous ones from light themes

[Thunder-Blaze]

Great work! some of the themes looks ugly.. cant be helped ig

well it was a shortcut rather than adding more colors XD

Is it possible to use #1d1d1d instead of #000, too much constrast for black parts

Seems possible will take a bit of time though ig

can you please exclude bookmarks favicons from color inverting

yeah sure

[Thunder-Blaze]

And the preload bg color is still prevoius ones from light themes

will try to fix (rn have no ideas execpt for storing a hasWallaper item and then fetching in preload)

[prem-k-r]

ok, take your time

[prem-k-r]

Great work! some of the themes looks ugly.. cant be helped ig

well it was a shortcut rather than adding more colors XD

Yeah, fantastic idea

[prem-k-r]

And the preload bg color is still prevoius ones from light themes

will try to fix (rn have no ideas execpt for storing a hasWallaper item and then fetching in preload)

fetch LoadingScreenColor from localstorage, then perform invert(1) hue-rotate(180deg) operation if toggle checked?
it sounds simple but operation part can be complicated

[prem-k-r]

When using color picker.. there is lots of processing.. so it lags lol
dont know if we can do anything if we want to show real time color

[Thunder-Blaze]

When using color picker.. there is lots of processing.. so it lags lol dont know if we can do anything if we want to show real time color

I might a way of easier theme making and the processing will be low in it imo but will try after theme code has been refactored rn can't understand most of it

btw #1d1d1d is mixing with the other colors, is it fine ?

[prem-k-r]

When using color picker.. there is lots of processing.. so it lags lol dont know if we can do anything if we want to show real time color

I might a way of easier theme making and the processing will be low in it imo but will try after theme code has been refactored rn can't understand most of it

ok,
I once was also working on it #162 (comment) needed css fixes and I'm not good at it.. meanwhile xengshi implemented current color picker.. It better for most user.. so I quit that

btw #1d1d1d is mixing with the other colors, is it fine ?

ah no, please use a shade in between them

[Thunder-Blaze]

When using color picker.. there is lots of processing.. so it lags lol dont know if we can do anything if we want to show real time color

I might a way of easier theme making and the processing will be low in it imo but will try after theme code has been refactored rn can't understand most of it

ok, I once was also working on it #162 (comment) needed css fixes and I'm not good at it.. meanwhile xengshi implemented current color picker.. It better for most user.. so I quit that

btw #1d1d1d is mixing with the other colors, is it fine ?

ah no, please use a shade in between them

oh it's a nice one
but I was talking about something like current one

ah no, please use a shade in between them

between black and 1d1d1d ?

[prem-k-r]

ah no, please use a shade in between them

between black and 1d1d1d ?

yeah, any that looks ok to you

[prem-k-r]

Btw, won't it be better if the toggle is available near the color palette..

Well this doesn't looks good,
umm.. can't think of any UI idea

[Thunder-Blaze]

Btw, won't it be better if the toggle is available near the color palette..

I also thought the same but there was no space 😞
In your design how about only one of icon ->

• If light mode is selected, show moon
• Otherwise show sun

[prem-k-r]

First I thought of that, some user might not understand it's clickable..
But we can go with it anyways lol

I mean only one icon.. opposite one

[Thunder-Blaze]

First I thought of that, some user might not understand it's clickable.. But we can go with it anyways lol

I mean only one icon.. opposite one

yeah that's also true 😅

[prem-k-r]

if u need svg https://www.transfernow.net/dl/20250112i9KY6Sdn
or u can use diff one

[Thunder-Blaze]

if u need svg https://www.transfernow.net/dl/20250112i9KY6Sdn or u can use diff one

thanks :)

[prem-k-r]

Maybe we can go ahead with this, if you exclude bookmarks favicons from color inverting, as this is still in experimental phase..
Later we can resolve related issues like loading color, toggle.. etc

[Thunder-Blaze]

Maybe we can go ahead with this, if you exclude bookmarks favicons from color inverting, as this is still in experimental phase.. Later we can resolve related issues like loading color, toggle.. etc

hmm sure 👍🏻

[prem-k-r]

seems all fine to me (except the screen loading color), great work!