Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed User Text Position #467

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Thunder-Blaze
Copy link
Contributor

📝 Description

  • The Custom Text doesn't goes over Clock no matter what.
  • Custom Text is limited to 3 lines, after that it becomes scrollable

📸 Screenshots / 📹 Videos

1400+
image
1200+
image
700+
image

🔗 Related Issues

✅ Checklist

  • I have read and followed the Contributing Guidelines.
  • I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
  • I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
  • Attached visual evidence of changes (screenshots or videos) if applicable.

@Thunder-Blaze
Copy link
Contributor Author

I'll add support for 500px and 500-700 after Responsive one gets merged

@prem-k-r
Copy link
Collaborator

Can you please check for digital clock too..
If possible can we move text and date div slightly up, for digital clock.. 1200+.. there was good gap between them

@prem-k-r prem-k-r added enhancement New feature or request bug fixes If there is any problem there this will fix it labels Jan 11, 2025
@Thunder-Blaze
Copy link
Contributor Author

Done for the Digital Clock 👍🏻

@prem-k-r
Copy link
Collaborator

Thanks :)

prem-k-r
prem-k-r previously approved these changes Jan 11, 2025
Copy link
Collaborator

@prem-k-r prem-k-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@prem-k-r prem-k-r added the ready to merge The pull request is ready to merge label Jan 11, 2025
itz-rj-here
itz-rj-here previously approved these changes Jan 11, 2025
@prem-k-r prem-k-r dismissed stale reviews from itz-rj-here and themself via 47c93f5 January 11, 2025 18:33
prem-k-r
prem-k-r previously approved these changes Jan 11, 2025
@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 14, 2025

Whole screen is moving upward a bit when the third line appears
and space between left and right div increases a bit if length crosses a fixed width

@Thunder-Blaze
Copy link
Contributor Author

I'll fix it tomorrow, maybe have to reduce the max height a bit

@prem-k-r prem-k-r removed the ready to merge The pull request is ready to merge label Jan 14, 2025
@itz-rj-here itz-rj-here added the changes required PR requires updates based on review feedback label Jan 15, 2025
@Thunder-Blaze
Copy link
Contributor Author

Whole screen is moving upward a bit when the third line appears and space between left and right div increases a bit if length crosses a fixed width

can you tell me at which width and height it is happening ?
I reduced the height a little, but idk if it fixes it or not as it was working fine for me previously too

@prem-k-r
Copy link
Collaborator

max-width: 300px or 18.75rem ; (width of clock)

@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 15, 2025

height:

Untitled.video.-.Made.with.Clipchamp.2.mp4

in both clock

@itz-rj-here
Copy link
Collaborator

@Thunder-Blaze the height shouldn’t be increased or decreased when using to write something on custom text.

@prem-k-r prem-k-r added ready to merge The pull request is ready to merge and removed changes required PR requires updates based on review feedback labels Jan 16, 2025
@prem-k-r
Copy link
Collaborator

changed a bit, please check if this ok

@Thunder-Blaze
Copy link
Contributor Author

Oh yeah, it's fine
I forgot about setting width to 18.75 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixes If there is any problem there this will fix it enhancement New feature or request ready to merge The pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click Here to edit bar problem.
3 participants