-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search mode categorization #474
base: main
Are you sure you want to change the base?
Conversation
…bloom/materialYouNewTab into Search-Mode-Categorization
added search mode categorization
I can add the animations, can you explain the 1st one in a bit more detail |
I think something like: |
Oh then I'll be able to add this too 👍🏻 |
I worked on the 1st problem any suggestions how to fix ? |
added default search mode selection
…bloom/materialYouNewTab into Search-Mode-Categorization
@Thunder-Blaze I Just finished the patch a few seconds ago and then read your comment, I was also facing the same issue and I don't think it can be fixed unless the whole structure is tweaked, because z-index, overflow nothing seems to be working so I intertwined the animation |
…bloom/materialYouNewTab into Search-Mode-Categorization
@prem-k-r ready to be pushed! 🎉
#❇️Fixes
#📸Preview Preview.474.mp4 |
I made a PR, check it |
optimized default selection by utilizing the local storage method!
I just finished testing works perfectly well done! |
Great work guys! umm, also maybe we can add ripple effect on button click |
@ashesbloom are you working on it or should I finish it ? |
@Thunder-Blaze sure go ahead I am switching to a new issue, will come back time to time though! |
ok 👍🏻 |
@ashesbloom Done, you can check the PR @prem-k-r I went with simple CSS riple effect otherwise there would've been lots of useless JS added just for one ripple animation |
Ripple Effect and Translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working fine overall.
I'm a bit iffy about some animations, let's wait for Xengshi.
And I think the toggle between "Search with" and "Search on" should be temporary, with "Search with" as the default. Need more opinions on this.
@Thunder-Blaze @prem-k-r though I think it can be more fluid, I'll create a better patch later today. |
If we make it temp maybe we can also avoid animation when page reloaded/NewTab opened |
📝 Description
Improvements Needed:
Selection Issue
Animation Enhancement
📸 Screenshots / 📹 Videos
Preview.359.mp4
🔗 Related Issues
✅ Checklist