Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Adaptive Icon css for Better Favicon Visibility #477

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Updated Adaptive Icon css for Better Favicon Visibility #477

merged 2 commits into from
Jan 19, 2025

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Jan 15, 2025 •
edited
Loading

📝 Description

  • Changed the mix-blend-mode property from lighten to screen, enhancing visibility, especially for red tones and other darker colors.
  • Adjusted the contrast to ensure consistency with the new blend mode.

📸 Screenshots / 📹 Videos

Before:
image

After:
image

🔗 Related Issues

NA

✅ Checklist

  • I have read and followed the Contributing Guidelines.
  • I have tested my changes by installing them as an extension (not just running via localhost) to ensure it builds, installs, and works as expected.
  • I have tested these changes in at least Chrome and Firefox (other browsers if applicable).
  • Attached visual evidence of changes (screenshots or videos) if applicable.

@prem-k-r prem-k-r added the enhancement New feature or request label Jan 15, 2025
@itz-rj-here
Copy link
Collaborator

Very small changes but very effective.

itz-rj-here
itz-rj-here previously approved these changes Jan 16, 2025
View reviewed changes
@itz-rj-here itz-rj-here added the ready to merge The pull request is ready to merge label Jan 16, 2025
@prem-k-r
Update script.js
d351705 
removed constast
@prem-k-r
Copy link
Collaborator Author

Removed constast as Netflix, Pinterest still barely visible
before was invisible

last
image

current
image

@prem-k-r prem-k-r requested a review from itz-rj-here January 18, 2025 17:49
@XengShi XengShi merged commit e774e33 into XengShi:main Jan 19, 2025
@prem-k-r prem-k-r deleted the adaptive-icon-visibility branch January 19, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itz-rj-here itz-rj-here itz-rj-here approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ready to merge The pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prem-k-r @itz-rj-here @XengShi