Updated the firefox manifests. Also fixed the icon of the home page tab. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Icon issue on the tab. Also Fixed the error which was showing on the extension manager in chrome.
itz-rj-here
changed the title
|
I will fix the conflicts after i come home. |
|
Could you also remove extra access for Firefox too? |
I fixed it, now you can modify manifest for Firefox. |
As you say. But i just came from school. I need to go to bath. Doing it after i finish taking bath. |
|
@XengShi, could you please review this PR? |
|
@XengShi ? |
itz-rj-here
changed the title
|
Getting some warnings
|
on it |
|
@XengShi Done. Just removed the president thingy and it fixed nice :) |
|
I forgot that its the manifest v3 not v2 that was my mistake sorry :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.