Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating Fresh PR: Manual Location + Translation #78

Merged
merged 8 commits into from
Oct 20, 2024
Merged

Creating Fresh PR: Manual Location + Translation #78

merged 8 commits into from
Oct 20, 2024

Conversation

prem-k-r
Copy link
Contributor

@prem-k-r prem-k-r commented Oct 20, 2024 •
edited
Loading

  • Translated newly added options of Digital clock element in menu
  • Added an option to input the location manually.
  • Customized date displayed formatting in Hindi and Bangla: Show full name for month and truncated week days.
  • Added missing translations of almost all of the interface elements to English and provided corresponding Hindi and Bangla translations.
  • Mapping of week day in hindi. (It was Sun-Sat in English but corresponding in Hindi was Mon-Sun, so was showing wrong day(current week day+1) in Hindi)
  • Reordered Language selection alphabetically.

@prem-k-r
Copy link
Contributor Author

Please review and merge, Thanks.

@XengShi
Copy link
Owner

XengShi commented Oct 20, 2024

Okay!

@prem-k-r prem-k-r mentioned this pull request Oct 20, 2024
Closed
Minuga-RC
Minuga-RC approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@Minuga-RC Minuga-RC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

@prem-k-r
Added Bangla Translation
36ba932
@prem-k-r
Bangla language formatting: Show full name for month
386662c 
For languages like Hindi and Bengali, using only the first three characters of a month, as done by default in English (e.g., 'Oct' for October), often creates ambiguous words.
@prem-k-r
Copy link
Contributor Author

Added Bangla translation.
I'm done

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 20, 2024

Ok, new PR… 😅 So, let me know when I can add missing Czech translation strings, please 🙂. Otherwise I'll add it after merging (it should notify me automatically).

itz-rj-here
itz-rj-here approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @prem12321kumar. just what we needed. Thanks for your hard work.
@XengShi you can merge this too. Its good to go.

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 20, 2024

Nice! I'll look at it, when I have a little time.

@itz-rj-here
Copy link
Contributor

Is it possible to edit the numbers too?
like it doesn't look good when changing the language to other but the number remains english.

@itz-rj-here
Copy link
Contributor

I just want to know if it is?..

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 20, 2024

Is it possible to edit the numbers too?

What numbers do you mean?

@itz-rj-here
Copy link
Contributor

Is it possible to edit the numbers too?

What numbers do you mean?

The weather degrees and the digital clock time and the date numbers.

@prem-k-r
Copy link
Contributor Author

It should be, let me try

@itz-rj-here
Copy link
Contributor

It should be, let me try

Yeah try. Until I make the new release notes.

@prem-k-r
Copy link
Contributor Author

Can check later. Letting current pr merge for now.

image
Temperature messed up.

@itz-rj-here
Copy link
Contributor

Can check later. Letting current pr merge for now.

image Temperature messed up.

Just try, don't already merge it. If you make it then add it to the pr.

@XengShi
Copy link
Owner

XengShi commented Oct 20, 2024

Unfortunately getting some conflicts, Could you please resolve it.

@itz-rj-here
Copy link
Contributor

@prem12321kumar

itz-rj-here
itz-rj-here suggested changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the conflicts.

@XengShi
Copy link
Owner

XengShi commented Oct 20, 2024

I checked your repo, and you've done an excellent job! I have a few suggestions for you:

You changed 'यहाँ अपना टेक्स्ट लिखें' to 'संपादित करने के लिए दो बार टैप करें.' While your translation is more accurate for 'Double tap to Edit,' I believe 'यहाँ अपना टेक्स्ट लिखें' is simpler and easier for users to understand, and it's also shorter, like 'Double tap to Edit.'

For the Enter button, you changed it to 'दर्ज करें,' which is indeed the correct translation of 'Enter,' but in my opinion, 'सर्च करें' would be more appropriate in Hindi.

Bugs: After switching to other languages like Chinese, Russian, and Portuguese, we are seeing 'undefined' translations.

@prem-k-r
Copy link
Contributor Author

Thanks.
let me make suggested change:
You changed 'यहाँ अपना टेक्स्ट लिखें' to 'संपादित करने के लिए दो बार टैप करें.' While your translation is more accurate for 'Double tap to Edit,' I believe 'यहाँ अपना टेक्स्ट लिखें' is simpler and easier for users to understand, and it's also shorter, like 'Double tap to Edit.'
For the Enter button, you changed it to 'दर्ज करें,' which is indeed the correct translation of 'Enter,' but in my opinion, 'सर्च करें' would be more appropriate in Hindi.

as for the Bugs: After switching to other languages like Chinese, Russian, and Portuguese, we are seeing 'undefined' translations.
this is due to translation not provided. it will show fine after translation. i'll do MTL for it

I was not free, i'll do by an hour or so and confirm you same

@itz-rj-here
Copy link
Contributor

@XengShi

itz-rj-here
itz-rj-here approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@XengShi
Copy link
Owner

XengShi commented Oct 20, 2024

@prem12321kumar
"....is due to translation not provided. it will show fine after translation. i'll do MTL for it...."

If translation is not provided simply use default 'English' just like the previous version.

@itz-rj-here
Copy link
Contributor

What happend?

@prem-k-r
Copy link
Contributor Author

Earlier English was showing when was it was not defined in any other language and methods were not defined for it.
give me few minutes, I am editing.
for any new untranslated element defined in future it will show in English, unless define in any other lang

@prem-k-r
Copy link
Contributor Author

@XengShi Done, Please check

@prem-k-r
Copy link
Contributor Author

Verified on my end

@XengShi XengShi merged commit ce78010 into XengShi:main Oct 20, 2024
@prem-k-r
Copy link
Contributor Author

@ceskyDJ you can verify Czech translation now

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Oct 20, 2024

@ceskyDJ you can verify Czech translation now

Nice! Thanks for notifying me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minuga-RC Minuga-RC Minuga-RC approved these changes

@itz-rj-here itz-rj-here itz-rj-here approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prem-k-r @XengShi @ceskyDJ @itz-rj-here @Minuga-RC