Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected datatypes of BatchPayment model #526

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Corrected datatypes of BatchPayment model #526

merged 5 commits into from
Nov 29, 2022

Conversation

JRising-Xero
Copy link
Contributor

@JRising-Xero JRising-Xero commented Nov 22, 2022 •
edited by RettBehrens
Loading

Description

  • Updated data type of IsReconciled property of BatchPayment to boolean.
  • Updated data type of TotalAmount property of BatchPayment to decimal
    Related to this issue

Release Notes

  • Data types did not align with data returned by Accounting API.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@JRising-Xero JRising-Xero changed the title Changed IsReconciled datatype of boolean Changed IsReconciled datatype to boolean Nov 22, 2022
@JRising-Xero JRising-Xero changed the title Changed IsReconciled datatype to boolean Corrected datatypes of BatchPayment model Nov 24, 2022
@RettBehrens RettBehrens merged commit 7dff86e into master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RettBehrens RettBehrens RettBehrens approved these changes

@rlayhbrian rlayhbrian Awaiting requested review from rlayhbrian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JRising-Xero @RettBehrens