Adds support for Windows #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 31, 2015 13:51
Testing fixes to Windows by completely resolving the path when removing files. Related to #118
unlinkSync doesn't appear to work on Windows
fs-tools' remove method doesn't work with Windows and rimraf does. Replaced all places where remove was used with rimraf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects a handful of issues:
fs.unlinkin favor offs.unlinkSyncwhich doesn't work on Windowsrimrafin favor offs-toolswhich doesn't work on Windowspath.resolvein favor ofpath.joinwhich may or may not actually fix anythingWorks for Meteor 1.1(.1) on both Windows and OS X.
Closes #118