Fix exit code. #32
Merged
Fix exit code. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
reviewed
Jul 15, 2019
| @@ -52,6 +52,8 @@ function main(args) { | |||
| } | |||
|
|
|||
| spinner.stop(); | |||
|
|
|||
| process.exit(unusedList.length); | |||
There was a problem hiding this comment.
Shouldn't we follow some rules about command lines exit codes? For example: https://www.tldp.org/LDP/abs/html/exitcodes.html
There was a problem hiding this comment.
Well, it depends. If no error occurs, we exit with 0. Then instead of 1 we just exit with >=1.
Either way works for me, but this solution has the advantage you can tell the number of unused variables by the exit code.
There was a problem hiding this comment.
I would prefer to display clearly the number of unused variables instead of an error code which shows that, but your call here
Johann-S
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31