Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-33 #37

Merged
merged 1 commit into from
Aug 21, 2019
Merged

bug-33 #37

merged 1 commit into from
Aug 21, 2019

Conversation

Khazl
Copy link
Contributor

@Khazl Khazl commented Aug 21, 2019 •
edited by XhmikosR
Loading

  • Improved RegExp & tests extended

Fixes #33

@XhmikosR
Copy link
Owner

Thanks @Khazl but I actually just think we need something like a11b215

This change doesn't belong in the regExpQuote function.

@XhmikosR XhmikosR force-pushed the master branch 2 times, most recently from c0180da to f101054 Compare August 21, 2019 08:44
@XhmikosR
Copy link
Owner

Alright, I rebased your branch and moved the regex where it's used.

/CC @Johann-S

@XhmikosR XhmikosR requested a review from Johann-S August 21, 2019 08:49
@XhmikosR
Fix regex.
3ead715 
Previously it wrongfully matched variables even if their name just started with another variable's name.
@Khazl
Copy link
Contributor Author

Khazl commented Aug 21, 2019

Perfect, do you like to publish a new version to npmjs?

@XhmikosR XhmikosR merged commit d890cdc into XhmikosR:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@Johann-S Johann-S Johann-S approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused variable is not detected
3 participants
@Khazl @XhmikosR @Johann-S