Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with without error message when regression data not written. #469

Open
Xiangyu-Hu opened this issue Nov 11, 2023 · 6 comments · Fixed by #682
Open

Crash with without error message when regression data not written. #469

Xiangyu-Hu opened this issue Nov 11, 2023 · 6 comments · Fixed by #682
Assignees

Comments

@Xiangyu-Hu
Copy link
Owner

Xiangyu-Hu commented Nov 11, 2023

The regression test class is defined but not used to output data.
For example in the water exit case, one define the test:

RegressionTestDynamicTimeWarping<ObservedQuantityRecording<Real>>
write_cylinder_wetting("Phi", io_environment, wetting_observer_contact);

But forget to write the output file, and still try to generate the regression test data by:
write_cylinder_wetting.generateDataBase(1.0e-3);

When I run the python script, I obtained crash information, but not able find the reason,
that I actually have not write out data.
Therefore, we need an error handler so that one can notice that the data file was not written.

@Xiangyu-Hu Xiangyu-Hu changed the title Crash with without error message when reggression data not written. Crash with without error message when regression data not written. Nov 11, 2023
@Bo-Zhang1995
Copy link
Collaborator

I will have a look on that.

@Xiangyu-Hu
Copy link
Owner Author

Another issue is that there is repeating data, the the reading the xml lead to error and and the regression data can nor be generated.

@Xiangyu-Hu
Copy link
Owner Author

@Bo-Zhang1995 Please look the these bugs.

@Bo-Zhang1995
Copy link
Collaborator

Bo-Zhang1995 commented Jan 28, 2024 via email

@Xiangyu-Hu
Copy link
Owner Author

@Bo-Zhang1995 How about this bug?

@Bo-Zhang1995
Copy link
Collaborator

This means that the input/output scheme of the database should be optimized, as we discussed during lunch.
The existing database will result in no new data being generated. I think this could be optimized by adding some alerts to warn when the data is repeated in the database. I will take some time to optimize it. Sorry for that the last time I was in China.

Bo-Zhang1995 added a commit that referenced this issue Nov 11, 2024
Here, the database will be emptied for each new generation, therefore, this problem can be solved.
Xiangyu-Hu added a commit that referenced this issue Nov 22, 2024
@Bo-Zhang1995 Bo-Zhang1995 linked a pull request Dec 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants