-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xiangyu/physical closure #717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xiangyu-Hu
requested review from
DongWuTUM,
WeiyiVirtonomy,
yyc84,
FengWang3119 and
Lisu-lisa
January 5, 2025 13:03
DongWuTUM
approved these changes
Jan 5, 2025
Lisu-lisa
approved these changes
Jan 6, 2025
src/shared/particle_dynamics/fluid_dynamics/non_newtonian_dynamics/non_newtonian_dynamics.cpp
Outdated
Show resolved
Hide resolved
src/shared/particle_dynamics/fluid_dynamics/non_newtonian_dynamics/non_newtonian_dynamics.h
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The material model now is generalized to physical closure.
Under this, material model (basically equation of state for fluid, and constitute relation for solid)
is considered as the base model, and viscosity is split and considered as an auxiliary model.
By such generalization, single species and multi-species diffusion are considered as auxiliary models.
However, I have not decide whether reaction system should be one part of closure or still belongs to diffusion reaction, as their relations are still not clarified.
As a straightforward extension, one can include turbulence models into the closure too.
The follows are copilot generated summary:
This pull request includes several changes aimed at improving the material handling and diffusion dynamics in the SPHinXsys library. The most important changes include the introduction of closures, removal of weakly compressible fluid materials, and enhancements to diffusion dynamics.
Material Handling Improvements:
modules/structural_simulation/structural_simulation_class.cpp
: Changed material assignment to usedefineMaterial<SaintVenantKirchhoffSolid>
instead ofassignMaterial
.src/shared/bodies/base_body.h
: Introduced a newdefineClosure
method for defining closures and removed theassignMaterial
method.Removal of Weakly Compressible Fluid Materials:
src/shared/materials/weakly_compressible_fluid.cpp
andsrc/shared/materials/weakly_compressible_fluid.h
: Removed the entire implementation of weakly compressible fluid materials and their associated classes.Only the base model is kept. [1] [2]
Diffusion Dynamics Enhancements:
src/shared/particle_dynamics/diffusion_reaction_dynamics/diffusion_dynamics.cpp
: Added a new implementation forGetDiffusionTimeStepSize
to compute time step size based on diffusion coefficient and particle smoothing length.src/shared/particle_dynamics/diffusion_reaction_dynamics/diffusion_dynamics.h
: Simplified theGetDiffusionTimeStepSize
class and modifiedDiffusionRelaxation
to improve species registration and update methods. [1] [2]Other Changes:
src/shared/io_system/io_environment.cpp
andsrc/shared/io_system/io_environment.h
: Changed thedefineParameterizationIO
method to return a pointer instead of a reference. [1] [2]src/shared/common/common_functors.h
: Introduced a newConstructArgs
template struct for handling constructor arguments.