Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xiangyu/physical closure #717

Merged
merged 26 commits into from
Jan 9, 2025
Merged

Xiangyu/physical closure #717

merged 26 commits into from
Jan 9, 2025

Conversation

Xiangyu-Hu
Copy link
Owner

@Xiangyu-Hu Xiangyu-Hu commented Jan 2, 2025

The material model now is generalized to physical closure.
Under this, material model (basically equation of state for fluid, and constitute relation for solid)
is considered as the base model, and viscosity is split and considered as an auxiliary model.

By such generalization, single species and multi-species diffusion are considered as auxiliary models.
However, I have not decide whether reaction system should be one part of closure or still belongs to diffusion reaction, as their relations are still not clarified.

As a straightforward extension, one can include turbulence models into the closure too.

The follows are copilot generated summary:

This pull request includes several changes aimed at improving the material handling and diffusion dynamics in the SPHinXsys library. The most important changes include the introduction of closures, removal of weakly compressible fluid materials, and enhancements to diffusion dynamics.

Material Handling Improvements:

Removal of Weakly Compressible Fluid Materials:

  • src/shared/materials/weakly_compressible_fluid.cpp and src/shared/materials/weakly_compressible_fluid.h: Removed the entire implementation of weakly compressible fluid materials and their associated classes.
    Only the base model is kept. [1] [2]

Diffusion Dynamics Enhancements:

Other Changes:

  • src/shared/io_system/io_environment.cpp and src/shared/io_system/io_environment.h: Changed the defineParameterizationIO method to return a pointer instead of a reference. [1] [2]
  • src/shared/common/common_functors.h: Introduced a new ConstructArgs template struct for handling constructor arguments.

@Xiangyu-Hu Xiangyu-Hu marked this pull request as draft January 2, 2025 23:07
@Xiangyu-Hu Xiangyu-Hu marked this pull request as ready for review January 5, 2025 13:15
@Xiangyu-Hu Xiangyu-Hu merged commit b20865c into master Jan 9, 2025
7 checks passed
@Xiangyu-Hu Xiangyu-Hu deleted the xiangyu/physical_closure branch January 9, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants