Add Surface Indication With CK/SYCL? Feature to SPHinXsys #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuVirtonomy
changed the title
|
@YuVirtonomy It is great to see that you are working on sycl code now. Could you also add a the surface indicating in the dambreak case in test_sycl for testing sycl implementation? |
|
@YuVirtonomy is this pull request ready for review and merge? |
Done, work exactly the same as ck version.
Seem test are passed. Can you review it please? |
Xiangyu-Hu
reviewed
Jan 15, 2025
.../shared_ck/particle_dynamics/general_dynamics/surface_indication/all_surface_indication_ck.h
Show resolved
Hide resolved
Xiangyu-Hu
reviewed
Jan 15, 2025
...ed/shared_ck/particle_dynamics/general_dynamics/surface_indication/surface_indication_ck.hpp
Outdated
Show resolved
Hide resolved
…ed clarity and structure In current structure, IndicatorCK for surface indicator is not needed
Xiangyu-Hu
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective: Add a surface indication class for CK version
New Feature: Surface Indication in ck
src/shared/shared_ck/particle_dynamics/general_dynamics/all_general_dynamics_ck.h: Added an include directive for the newall_surface_indication_ck.hheader file.src/shared/shared_ck/particle_dynamics/general_dynamics/surface_indication/all_surface_indication_ck.h: Added a new header file with licensing information and inclusion of thesurface_indication_ck.hppheader.src/shared/shared_ck/particle_dynamics/general_dynamics/surface_indication/surface_indication_ck.h: Added the main header file for surface indication, defining theIndicatorCKandFreeSurfaceIndicationCKclasses with their respective methods and members.src/shared/shared_ck/particle_dynamics/general_dynamics/surface_indication/surface_indication_ck.hpp: Added the implementation file for theFreeSurfaceIndicationCKclass, detailing the constructors and methods for interaction and update kernels.Test Example Update
tests/2d_examples/2d_examples_ck/test_2d_dambreak_ck/dambreak_ck.cpp: Updated the 2D dam break test example to include the new surface indication functionality, adding thefluid_boundary_indicatorand recording theSurfaceIndicatorandPositionDivergencevariables. [1] [2] [3]surface_indicator.mp4