This repository has been archived by the owner on May 10, 2022. It is now read-only.
refactor: delete duplicate config and use ClientOptions uniformly #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Jul 24, 2020
src/main/java/com/xiaomi/infra/pegasus/client/PegasusClient.java
Outdated
Show resolved
Hide resolved
…lient into refactor-options
levy5307
approved these changes
Jul 24, 2020
neverchanje
reviewed
Aug 4, 2020
| @@ -35,6 +35,11 @@ | |||
| <artifactId>metrics-core</artifactId> | |||
| <version>3.1.2</version> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.apache.commons</groupId> | |||
| <artifactId>commons-configuration2</artifactId> | |||
There was a problem hiding this comment.
Yeah, but If it hasn't compatibility problems, it maybe no need to be shaded, otherwise, should all dependencys be shaded?
There was a problem hiding this comment.
I'm afraid so. The deps for non-testing code generally need to be shaded in case of dep conflict.
But given the apache.common.configuration2 is not much used here, we can leave it unshaded for now.
neverchanje
approved these changes
Aug 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the config of
PegasusClientis duplicate, which existed inClusterOptions(it loads from config file) andClientOptions(it is created manualy), this PR del theClusterOptionsand useClientOptionsuniformly.