Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

fix: return value of asyncNext should use netty future #155

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

ZhongChaoqiang
Copy link
Contributor

No description provided.

@foreverneverer
Copy link
Contributor

Thanks for your contribution @ZhongChaoqiang .

Change api usually cause compatibility problem and we haven't find the futurebug, so I want to know why you need use netty future, do you meet some bug or some other problem? you can add some description to explain it.

@neverchanje
Copy link

Agree with Shuo Jia. It's not trivial to introduce API change. You can describe your requirement and I think we can find out some way that can work around incompatibility.

@ZhongChaoqiang
Copy link
Contributor Author

ZhongChaoqiang commented Apr 28, 2021

@shuo-jia @neverchanje
I don't know whether the original design is to return to the future of jdk. I thought this was a mistake.
If we change to netty future, the code on the application side is not affected because netty future inherits the future of the JDK. In addition, listener can be added without forcible conversion, which is convenient to use.
All other aync APIs use netty future,It's also about uniform usage.

@foreverneverer foreverneverer changed the title return value of asyncNext should use netty future fix: return value of asyncNext should use netty future Apr 28, 2021
@foreverneverer
Copy link
Contributor

@ZhongChaoqiang good, it's right, I have approved

@levy5307
Copy link
Contributor

@ZhongChaoqiang Thanks for your contribution. Maybe you should add a commit to make the check of semantic succeed. Thanks!

@neverchanje neverchanje merged commit fdcdc6f into XiaoMi:master Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants