This repository has been archived by the owner on May 10, 2022. It is now read-only.
re-implement getting forward address from configuration_query_by_inde… #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
requested review from
shengofsun,
neverchanje,
acelyc111 and
hycdong
hycdong
reviewed
Jan 14, 2019
| needDelay = true; | ||
| needSwitchLeader = false; | ||
| needDelay = false; | ||
| needSwitchLeader = true; |
There was a problem hiding this comment.
现在onFinishQueryMeta的逻辑变成了只要query meta失败就立即switch meta，ERR_SERVICE_NOT_ACTIVE和ERR_FORWARD_TO_OTHERS这两个错误码，就没有区别了，我理解ERR_SERVICE_NOT_ACTIVE是指当前meta是leader，但是只是暂时不可用，可以不用switch的
There was a problem hiding this comment.
这里考虑了一下，确实还是应当维持原来的逻辑：ERR_SERVICE_NOT_ACTIVE是指当前meta是leader，但是只是暂时不可用，可以不用switch，但是要delay。
hycdong
reviewed
Jan 14, 2019
| @@ -136,7 +141,7 @@ else if (metaError == error_types.ERR_FORWARD_TO_OTHERS) { | |||
| } | |||
| } | |||
| else if (op.rpc_error.errno == error_types.ERR_SESSION_RESET || op.rpc_error.errno == error_types.ERR_TIMEOUT) { | |||
| needDelay = true; | |||
| needDelay = false; | |||
There was a problem hiding this comment.
遇到timeout和reset也不delay了，也是立即switch吗？
There was a problem hiding this comment.
是的。reset一般是connection refused，说明meta-server进程未启动，应当立即switch；timeout的时候可能是网络出了问题，处于保险还是switch比较好。
hycdong
approved these changes
Jan 14, 2019
acelyc111
approved these changes
Jan 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…x_response
we re-implement it in other way to fix compatibility problem of #27
for the reason, please refer to XiaoMi/rdsn#217