Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

Adapt to partition split #44

Merged
merged 5 commits into from
Apr 4, 2019
Merged

Conversation

hycdong
Copy link
Contributor

@hycdong hycdong commented Mar 21, 2019

Functions:

  • According to issue fill in partition_hash in thrift header #39 , we fill correct partition_hash value in thrift_header
  • Add need_check_hash filed in get_scanner_request
    • hash_scan scanner: need_check_hash = false
    • unordered_scan scanner: need_check_hash = true
    • After partition split, parent will hold data belonging to child, and child will also have data belonging to parent. As a result, we have to check hash while executing unordered_scan to remove duplicated data. However, we don't need to check hash while hash_scan. Hash_scan will scan only one partition, it won't have duplicated data.

Tests:
We run java client unit test succeed on different onebox with different server version:

  • client -> old server(version 1.11.3)
  • client -> new server(supporting partition split)

@hycdong hycdong merged commit 6bfc6d3 into XiaoMi:thrift-0.11.0-inlined Apr 4, 2019
neverchanje pushed a commit that referenced this pull request Sep 24, 2019
* fill in partition_hash in thrift header

* format code

* update unit test for server supporting partition split

* update unit tests
@hycdong hycdong deleted the split branch August 3, 2021 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants