Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

fix: set error to ERR_SESSION_RESET to trigger meta query while se… #54

Merged
merged 5 commits into from
Sep 24, 2019

Conversation

neverchanje
Copy link

@neverchanje neverchanje commented Sep 20, 2019

…ssion not responding.

Refer to #53

How does it work:

-            closeSession();
+            closeSession(); // maybe fail when the session is already disconnected.
+           errno = error_types.ERR_SESSION_RESET;

After close the session, we set error to ERR_SESSION_RESET, this error will definitely trigger
meta query, to update the local configuration table.

A potential problem is that every 10 seconds of continuous timeout errors will incur one meta query.
It may cause overload on meta-server. For example, when there are 100 clients concurrently loading data to Pegasus which causes many timeouts, the 100 clients will altogether request the single meta-server every 10 seconds.

In most cases, the scalability won't be a problem, but it should be awared.

@neverchanje neverchanje changed the title bugfix: set error to ERR_SESSION_RESET to trigger meta query while se… fix: set error to ERR_SESSION_RESET to trigger meta query while se… Sep 20, 2019
@qinzuoyan qinzuoyan merged commit 63ad1a5 into XiaoMi:thrift-0.11.0-inlined Sep 24, 2019
@neverchanje neverchanje deleted the rpcbug branch September 24, 2019 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants