This repository has been archived by the owner on May 10, 2022. It is now read-only.
refactor: add more exception info #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreverneverer
requested review from
neverchanje,
acelyc111,
hycdong,
shengofsun,
vagetablechicken,
levy5307 and
qinzuoyan
and removed request for
shengofsun
levy5307
reviewed
Oct 16, 2019
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
levy5307
reviewed
Oct 16, 2019
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
levy5307
reviewed
Oct 16, 2019
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
levy5307
reviewed
Oct 16, 2019
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Oct 16, 2019
src/main/java/com/xiaomi/infra/pegasus/rpc/async/TableHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Oct 17, 2019
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTable.java
Outdated
Show resolved
Hide resolved
neverchanje
approved these changes
Oct 17, 2019
foreverneverer
added a commit
that referenced
this pull request
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原有的异常信息仅给出错误码，例如ERR_OBJECT_NOT_FOUND，而没有详细的异常信息，这种错误：
1、用户不能明白具体含义
2、不利于问题追踪
该PR在抛异常处重新添加了处理异常的逻辑，细化各个错误码的具体描述，并给出必要的信息，修改过后的异常信息将类似：