This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(op_status_lock): add a command to unlock meta_op_status manually #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Jan 10, 2022
| @@ -228,6 +228,8 @@ class replication_ddl_client | |||
| error_with<query_app_manual_compact_response> | |||
| query_app_manual_compact(const std::string &app_name); | |||
|
|
|||
| dsn::error_code unlock_meta_op_status(); | |||
levy5307
reviewed
Jan 10, 2022
| @@ -1712,5 +1712,23 @@ replication_ddl_client::query_app_manual_compact(const std::string &app_name) | |||
| query_manual_compact_rpc(std::move(req), RPC_CM_QUERY_MANUAL_COMPACT_STATUS)); | |||
| } | |||
|
|
|||
| dsn::error_code replication_ddl_client::unlock_meta_op_status() | |||
| { | |||
| std::shared_ptr<unlock_meta_op_status_request> req = | |||
There was a problem hiding this comment.
auto req = std::make_shared<unlock_meta_op_status_request>();
levy5307
reviewed
Jan 10, 2022
| std::make_shared<unlock_meta_op_status_request>(); | ||
|
|
||
| auto resp_task = request_meta<unlock_meta_op_status_request>(RPC_CM_UNLOCK_META_OP_STATUS, req); | ||
|
|
levy5307
reviewed
Jan 10, 2022
src/meta/meta_service.cpp
Outdated
| { | ||
| ddebug_f("UNLOCK meta op status from {}", enum_to_string(_meta_op_status.load())); | ||
| ddebug_f("UNLOCK meta op status from {}, is_manual {}", |
There was a problem hiding this comment.
ddebug_f("UNLOCK meta op status from {}, is_manual = {}", enum_to_string(_meta_op_status.load()), is_manual);
There was a problem hiding this comment.
I wrote as you say, but modified by clang-format. It is not bad in multi lines.
There was a problem hiding this comment.
I mean add a = after is_manual
levy5307
reviewed
Jan 10, 2022
| } | ||
|
|
||
| unlock_meta_op_status_response resp; | ||
| ::dsn::unmarshall(resp_task->get_response(), resp); |
levy5307
reviewed
Jan 10, 2022
| @@ -1712,5 +1712,23 @@ replication_ddl_client::query_app_manual_compact(const std::string &app_name) | |||
| query_manual_compact_rpc(std::move(req), RPC_CM_QUERY_MANUAL_COMPACT_STATUS)); | |||
| } | |||
|
|
|||
| dsn::error_code replication_ddl_client::unlock_meta_op_status() | |||
hycdong
reviewed
Jan 10, 2022
| @@ -329,7 +329,7 @@ class app_info | |||
| expire_second(0), | |||
| create_second(0), | |||
| drop_second(0), | |||
| duplicating(0), | |||
| duplicating(false), | |||
There was a problem hiding this comment.
Why does this files change? It seems that related .thrift is not updated.
| @@ -162,7 +162,7 @@ class meta_service : public serverlet<meta_service> | |||
| size_t get_alive_node_count() const; | |||
|
|
|||
| bool try_lock_meta_op_status(meta_op_status op_status); | |||
| void unlock_meta_op_status(); | |||
| void unlock_meta_op_status(bool is_manual = false); | |||
There was a problem hiding this comment.
It seems that is_manual is useless, what is it usage?
There was a problem hiding this comment.
Just for debug log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache/incubator-pegasus#845
Add a command to unlock meta_op_status manually. And show meta_op_status in Pegasus shell : "cluster_info".