This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: make json_helper decoupled from dsn_runtime #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 2, 2020 18:50
acelyc111
approved these changes
Jul 4, 2020
neverchanje
reviewed
Jul 4, 2020
| @@ -214,11 +214,11 @@ | |||
| } | |||
|
|
|||
| #define NON_MEMBER_JSON_SERIALIZATION(type, ...) \ | |||
| inline void json_encode(dsn::json::JsonWriter &output, const type &t) \ | |||
| void json_encode(dsn::json::JsonWriter &output, const type &t) \ | |||
There was a problem hiding this comment.
In cpp, inline function must be defined in .h, but not .cpp. And we should move json_code function of gpid to gpid.cpp.
neverchanje
reviewed
Jul 4, 2020
Comment on lines
+342
to
+343
| void json_encode(JsonWriter &out, const dsn::gpid &pid); | ||
| bool json_decode(const dsn::json::JsonObject &in, dsn::gpid &pid); |
There was a problem hiding this comment.
Move the declaration to gpid.h.
Suggested change
| void json_encode(JsonWriter &out, const dsn::gpid &pid); | |
| bool json_decode(const dsn::json::JsonObject &in, dsn::gpid &pid); | |
| namespace json { | |
| class JsonWriter; | |
| class JsonObject; | |
| } // namespace json | |
| void json_encode(JsonWriter &out, const gpid &pid); | |
| bool json_decode(const JsonObject &in, gpid &pid); |
Do the same to other types.
There was a problem hiding this comment.
Why move the declaration to gpid.h? I think placed them centrally in one file is ok.
There was a problem hiding this comment.
The module itself should be responsible for its related code. There's no modularity if everything is in a central file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.