This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: restrict remote-command to only one command name #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
May 16, 2021
| } | ||
| } | ||
| dassert(is_valid_cmd, "should not register empty command"); | ||
| utils::auto_write_lock l(_lock); |
There was a problem hiding this comment.
auto c = new command_instance();
c->commands = commands;
c->help_long = help_long;
c->help_short = help_one_line;
c->handler = std::move(handler);
utils::auto_write_lock l(_lock);
_handlers[cmd] = c;
|
|
||
| void command_manager_module_init() | ||
| struct command_manager_test : public ::testing::Test |
There was a problem hiding this comment.
Suggested change
| struct command_manager_test : public ::testing::Test | |
| class command_manager_test : public ::testing::Test |
| @@ -38,29 +39,19 @@ dsn_handle_t command_manager::register_command(const std::vector<std::string> &c | |||
| const std::string &help_long, | |||
| command_handler handler) | |||
| { | |||
| utils::auto_write_lock l(_lock); | |||
| bool is_valid_cmd = false; | |||
| dcheck_eq(commands.size(), 1); | |||
There was a problem hiding this comment.
So commands can be replaced by const std::string &command ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.