Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix: fix data loss #815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZhongChaoqiang
Copy link
Contributor

What problem does this PR solve?

Data loss becase wrong init_durable_decree in .init-info file.
For details, see apache/incubator-pegasus#719

What is changed and how it works?

using last_durable_decree for init_durable_decree in .init-info file.

Check List

Tests

Manual test (add detailed scripts or steps below)

Copy link
Contributor

@zhangyifan27 zhangyifan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test showing that this works the way you expect?

@ZhongChaoqiang
Copy link
Contributor Author

@neverchanje @hycdong
Can you help to review the code?
Thanks!

@ZhongChaoqiang
Copy link
Contributor Author

Could you add a test showing that this works the way you expect?

@zhangyifan27
OK,I will try to add a unit test. But this is a little complicated. Can you recommend a similar test case for me? Thanks!

@Smityz
Copy link
Contributor

Smityz commented May 28, 2021

mentioned in apache/incubator-pegasus#719

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants