Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i386: build on 32-bit archs without 64-bit time_t #8

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

abower-amd
Copy link
Collaborator

Fixes #7 by defining an application-specific type sfptpd_secs_t which is int64_t. Some explicit format specifiers are also required.

Alternative approaches of using __time64_t or __TIME64_T_TYPE are not very compatible with old OSs; this approach is simpler than working with these.

Tested with 32-bit userspace, kernel and CPU

Linux cook 6.5.0-3-686 #1 SMP PREEMPT_DYNAMIC Debian 6.5.8-1 (2023-10-22) i686 GNU/Linux
UNIT TEST RESULTS SUMMARY
seed: 1715450424
Unit test Run Result
0 config Run Pass
1 hash Run Pass
2 stats Run Pass
3 filters Not run
4 threading Not run
5 bic Run Pass
6 fmds Not run
7 link Run Pass
8 time Run Pass
2024-02-01 09:40:33.999310: info: Solarflare Enhanced PTP Daemon, version 3.8.0.1000
2024-02-01 09:40:35.246050: debug: sync engine created successfully

PTP has also been observed working.

@abower-amd abower-amd requested review from matthewr-xilinx and a team February 1, 2024 10:38
Copy link
Contributor

@ivatet-amd ivatet-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build tested on 32-bit Raspberry Pi 3. 👍

@cns-ci-onload-xilinx cns-ci-onload-xilinx merged commit 56c1166 into Xilinx-CNS:master Feb 9, 2024
1 check passed
@abower-amd abower-amd deleted the i386 branch February 9, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i386: 32-bit builds fail due to time_t not being 64-bit
3 participants