Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It really looks like these were typos and thus dependencies are missed. #1440

Merged
merged 1 commit into from
May 1, 2024

Conversation

keithpenney
Copy link

To be honest, I didn't do much more than just:

grep -r --include="*akefile" --include="*.mk" --include="*.sh" --include="*.cmake" EMBEDDED_DIR
# exactly two hits; both empty dependencies with no associated targets

grep -r --include="*akefile" --include="*.mk" --include="*.sh" --include="*.cmake" EMBEDDEDSW_DIR
# 23 hits including defining the variable and an associated recipe

I won't pretend to understand the full build system, so it's entirely possible that this is actually intentional and there's some meta-scripting magic making this all work. Looks like a typo though.

@jogomojo jogomojo changed the base branch from master to image_v3.1 May 1, 2024 16:44
@jogomojo jogomojo merged commit fff1eaf into Xilinx:image_v3.1 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants