Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFB76::calculatePaddedNumElements #189

Open
laurent-onenano opened this issue Oct 28, 2023 · 1 comment
Open

CFB76::calculatePaddedNumElements #189

laurent-onenano opened this issue Oct 28, 2023 · 1 comment

Comments

@laurent-onenano
Copy link

It looks like this line is wrong and should be

numChunks = (numRequestedElements + NUM_ELEMENTS_PER_BUFFER_CHUNK - 1) / NUM_ELEMENTS_PER_BUFFER_CHUNK;

otherwise it simply adds 0 all the time and doesn't do what it's supposed to do.

numChunks = numRequestedElements + (NUM_ELEMENTS_PER_BUFFER_CHUNK - 1) / NUM_ELEMENTS_PER_BUFFER_CHUNK;

@laurent-onenano
Copy link
Author

Actually, it works if and only if NUM_ELEMENTS_PER_BUFFER_CHUNK = 1 otherwise fails in every other case.

vt-lib-support pushed a commit that referenced this issue May 30, 2024
337288c update (#189)
Co-authored-by: sdausr <sdausr@xilinx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant