VITIS-13434 Provide more error details for AIE async errors via xrt::error #8736
+162
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
2) avoid crash from getting hip mem object from null pointer 3) allow setting 0 for kernel arguments Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
…tation. Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
…t char*. Signed-off-by: Chiming <chimingz@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
Signed-off-by: Chiming Zhang <Chiming.Zhang@amd.com>
stsoe
reviewed
Feb 1, 2025
added 2 commits
February 2, 2025 22:52
Signed-off-by: Chiming <chimingz@amd.com>
Signed-off-by: Chiming <chimingz@amd.com>
zhangchiming
force-pushed
the
ex_error
branch
from
e650524 to
993d6b3
Compare
added 2 commits
February 2, 2025 22:59
Signed-off-by: Chiming <chimingz@amd.com>
Signed-off-by: Chiming <chimingz@amd.com>
stsoe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Initial check in for adding more error info (NPU error id, col and row) from driver to xrt::error.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
N/A
How problem was solved, alternative solutions (if any) and why they were rejected
Add another 64 bit error code to existing xrt::error_impl and it will be populated by device driver.
Risks (if any) associated the changes in the commit
Low, since the new code path will not be used until the NPU device driver code is updated with new error reporting.
What has been tested and how, request additional testing if necessary
Compile and tested on Windows 11 with both existing driver and the upcoming new driver with extra error code reporting.
Documentation impact (if any)
N/A