Feat: Remove QOP Export #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giuseppe5
reviewed
Mar 26, 2024
src/brevitas/export/manager.py
Outdated
| @@ -254,8 +205,6 @@ def _cache_inp_out(cls, module, *args, **kwargs): | |||
| module.apply(lambda m: _override_inp_caching_mode(m, enabled=True)) | |||
| module.apply(lambda m: _override_out_caching_mode(m, enabled=True)) | |||
| with ExitStack() as stack: | |||
There was a problem hiding this comment.
If we don't add anything to the stack, we can remove the context manager and leave the forward pass as part of the function
| @@ -280,8 +229,6 @@ def jit_inference_trace( | |||
| # force requires_grad to False to let the wrapped model lambda go through tracing | |||
| requires_grad_backup_dict = _force_requires_grad_false(module) | |||
| with ExitStack() as stack: | |||
| for mgr in cls._trace_patches(): | |||
| @@ -123,8 +123,6 @@ def export_onnx( | |||
| module.apply(lambda m: _override_inp_caching_mode(m, enabled=False)) | |||
| # perform export pass | |||
| with ExitStack() as stack: | |||
| for mgr in cls._trace_patches(): | |||
There was a problem hiding this comment.
Same as before, everything can be flattened one level down
…g put on the stack after changes
Giuseppe5
approved these changes
Mar 27, 2024
Giuseppe5
pushed a commit
to Giuseppe5/brevitas
that referenced
this pull request
Apr 12, 2024
Giuseppe5
pushed a commit
to Giuseppe5/brevitas
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
QOp export is not in use so can be removed to simplify code base
Changes Made in this PR
Remove QOp export code and references in documentation
Testing Summary
Relying on automated testing, functionality is being removed and none is being added
Risk Highlight
ONNX and Torch QOp export will no longer be possible
Checklist
devbranch.Future Work