Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Extend ptq_evaluate to allow switching between torchvision and timm datsets #946

Draft
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

costigt-dev
Copy link
Collaborator

Reason for this PR

To allow more datasets to be utilised

Changes Made in this PR

  • Modified get_model_config so that it would be compatible with the naming schemes of both torchvision and timm models
  • Added --dataset parameters (which defaults to torchvision) and removed choices field from --model-name parameter as it was populated by the model names and would now be over 1000 items long with timm included
  • finally added condition switching between using timm and torchvision methods for loading models.

Testing Summary

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Script now relies on timm package

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

Future Work

@costigt-dev costigt-dev changed the base branch from master to dev April 30, 2024 09:13
@costigt-dev costigt-dev marked this pull request as draft April 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants